Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inventory] search bar #192329

Closed
5 tasks done
smith opened this issue Sep 8, 2024 · 2 comments · Fixed by #193546
Closed
5 tasks done

[Inventory] search bar #192329

smith opened this issue Sep 8, 2024 · 2 comments · Fixed by #193546
Assignees
Labels
enhancement New value added to drive a business result Feature:EntitiesInventory Observability entities inventory feature Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@smith
Copy link
Contributor

smith commented Sep 8, 2024

Summary

Designs

Caution

Please review the designs on Figma - DESIGNS

(Screenshot taken on 12.09.2024)
Image
Image

Hints

The search bar provides renderQueryInputAppend to append a component after the input

 renderQueryInputAppend={() => (
        <div>
         "this is a dropdown
        </div>
)}

Acceptance criteria

  • Use Unified search
  • Placeholder: Search for your entities by name or its metadata (e.g. entity.type : service).
  • The suggested fields should be limited to what is available in the entities latest index
  • User can filter based on the entity.type. We should use the controls similar to Host We'll show a simple combo box for now.
  • The state should be sharable.
@smith smith added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team enhancement New value added to drive a business result needs-refinement A reason and acceptance criteria need to be defined for this issue Feature:EntitiesInventory Observability entities inventory feature labels Sep 8, 2024
@kpatticha kpatticha changed the title Inventory search bar [Inventory] search bar Sep 12, 2024
@kpatticha
Copy link
Contributor

Note: We need to verify if it's possible to pass a custom component between the search bar and the button.

@kpatticha kpatticha removed the needs-refinement A reason and acceptance criteria need to be defined for this issue label Sep 13, 2024
@crespocarlos
Copy link
Contributor

We need to store the search state in the querystring.

@cauemarcondes cauemarcondes self-assigned this Sep 18, 2024
cauemarcondes added a commit to cauemarcondes/kibana that referenced this issue Sep 23, 2024
cauemarcondes referenced this issue Sep 23, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory][ECO] Entities page search bar
(#193546)](#193546)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T13:59:15Z","message":"[Inventory][ECO]
Entities page search bar (#193546)\n\ncloses
https://github.com/elastic/kibana/issues/192329\r\n\r\n\r\nhttps://github.com/user-attachments/assets/eb4e7aa6-14dd-48fb-a076-98ceec9cb335\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>\r\nCo-authored-by:
Carlos Crespo
<[email protected]>","sha":"6a0fa96141086644bc8756a37babe43204e6c076","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.16.0"],"number":193546,"url":"https://github.com/elastic/kibana/pull/193546","mergeCommit":{"message":"[Inventory][ECO]
Entities page search bar (#193546)\n\ncloses
https://github.com/elastic/kibana/issues/192329\r\n\r\n\r\nhttps://github.com/user-attachments/assets/eb4e7aa6-14dd-48fb-a076-98ceec9cb335\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>\r\nCo-authored-by:
Carlos Crespo
<[email protected]>","sha":"6a0fa96141086644bc8756a37babe43204e6c076"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193546","number":193546,"mergeCommit":{"message":"[Inventory][ECO]
Entities page search bar (#193546)\n\ncloses
https://github.com/elastic/kibana/issues/192329\r\n\r\n\r\nhttps://github.com/user-attachments/assets/eb4e7aa6-14dd-48fb-a076-98ceec9cb335\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>\r\nCo-authored-by:
Carlos Crespo
<[email protected]>","sha":"6a0fa96141086644bc8756a37babe43204e6c076"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:EntitiesInventory Observability entities inventory feature Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants