Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UII] Fix unifiedSearch mock in SearchBar jest test #192211

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

jen-huang
Copy link
Contributor

@jen-huang jen-huang commented Sep 5, 2024

Summary

Resolves #181510. Fixes missing method in the mocked unifiedSearch dependency that was causing flaky test failures.

@jen-huang jen-huang added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Sep 5, 2024
@jen-huang jen-huang self-assigned this Sep 5, 2024
@jen-huang jen-huang requested a review from a team as a code owner September 5, 2024 18:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@jen-huang jen-huang enabled auto-merge (squash) September 5, 2024 19:13
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jen-huang

@jen-huang jen-huang merged commit 24e1b67 into elastic:main Sep 6, 2024
25 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 6, 2024
## Summary

Resolves elastic#181510. Fixes missing method in the mocked `unifiedSearch`
dependency that was causing flaky test failures.

(cherry picked from commit 24e1b67)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 6, 2024
…60; jest test (#192211) (#192239)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[UII] Fix `unifiedSearch` mock in `SearchBar`
jest test (#192211)](#192211)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jen
Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-06T06:42:47Z","message":"[UII]
Fix `unifiedSearch` mock in `SearchBar` jest test (#192211)\n\n##
Summary\r\n\r\nResolves #181510. Fixes missing method in the mocked
`unifiedSearch`\r\ndependency that was causing flaky test
failures.","sha":"24e1b67027c545176fed8d8b5f8b726d45245181","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.16.0"],"title":"[UII]
Fix `unifiedSearch` mock in `SearchBar` jest
test","number":192211,"url":"https://github.com/elastic/kibana/pull/192211","mergeCommit":{"message":"[UII]
Fix `unifiedSearch` mock in `SearchBar` jest test (#192211)\n\n##
Summary\r\n\r\nResolves #181510. Fixes missing method in the mocked
`unifiedSearch`\r\ndependency that was causing flaky test
failures.","sha":"24e1b67027c545176fed8d8b5f8b726d45245181"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192211","number":192211,"mergeCommit":{"message":"[UII]
Fix `unifiedSearch` mock in `SearchBar` jest test (#192211)\n\n##
Summary\r\n\r\nResolves #181510. Fixes missing method in the mocked
`unifiedSearch`\r\ndependency that was causing flaky test
failures.","sha":"24e1b67027c545176fed8d8b5f8b726d45245181"}}]}]
BACKPORT-->

Co-authored-by: Jen Huang <[email protected]>
@jen-huang jen-huang deleted the fix/181510 branch September 11, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.15.2 v8.16.0
Projects
None yet
6 participants