Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/fleet/public/applications/fleet/components - SearchBar renders the search box #181510

Closed
kibanamachine opened this issue Apr 24, 2024 · 5 comments · Fixed by #192211
Closed

Failing test: Jest Tests.x-pack/plugins/fleet/public/applications/fleet/components - SearchBar renders the search box #181510

kibanamachine opened this issue Apr 24, 2024 · 5 comments · Fixed by #192211
Assignees
@jen-huang
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 24, 2024 •
edited
Loading

A test failed on a tracked branch

TypeError: this.props.deps.unifiedSearch.autocomplete.hasQuerySuggestions is not a function
    at QueryStringInputUI.hasQuerySuggestions [as getSuggestions] (/var/lib/buildkite-agent/builds/kb-n2-4-spot-7ce2fa28bb968966/elastic/kibana-on-merge/kibana/src/plugins/unified_search/public/query_string_input/query_string_input.tsx:268:50)
    at QueryStringInputUI.getSuggestions (/var/lib/buildkite-agent/builds/kb-n2-4-spot-7ce2fa28bb968966/elastic/kibana-on-merge/kibana/src/plugins/unified_search/public/query_string_input/query_string_input.tsx:331:37)
    at invokeFunc (/var/lib/buildkite-agent/builds/kb-n2-4-spot-7ce2fa28bb968966/elastic/kibana-on-merge/kibana/node_modules/lodash/lodash.js:10401:23)
    at trailingEdge (/var/lib/buildkite-agent/builds/kb-n2-4-spot-7ce2fa28bb968966/elastic/kibana-on-merge/kibana/node_modules/lodash/lodash.js:10450:18)
    at timerExpired (/var/lib/buildkite-agent/builds/kb-n2-4-spot-7ce2fa28bb968966/elastic/kibana-on-merge/kibana/node_modules/lodash/lodash.js:10438:18)
    at Timeout.task [as _onTimeout] (/var/lib/buildkite-agent/builds/kb-n2-4-spot-7ce2fa28bb968966/elastic/kibana-on-merge/kibana/node_modules/jsdom/lib/jsdom/browser/Window.js:520:19)
    at listOnTimeout (node:internal/timers:573:17)
    at processTimers (node:internal/timers:514:7)

First failure: CI Build - 8.14
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Apr 24, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 24, 2024
@kibanamachine kibanamachine added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 24, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kpollich kpollich assigned criamico and jen-huang and unassigned criamico Aug 13, 2024
@jen-huang
Copy link
Contributor

We no longer use unifiedSearch.autocomplete.hasQuerySuggestions in this component. Closing.

@jen-huang jen-huang closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
@kibanamachine kibanamachine reopened this Sep 4, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@jen-huang jen-huang mentioned this issue Sep 5, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 6, 2024
@jen-huang
[UII] Fix unifiedSearch mock in SearchBar jest test (elastic#192211)
a4b5bce 
## Summary

Resolves elastic#181510. Fixes missing method in the mocked `unifiedSearch`
dependency that was causing flaky test failures.

(cherry picked from commit 24e1b67)
kibanamachine added a commit that referenced this issue Sep 6, 2024
@kibanamachine @jen-huang
[8.15] [UII] Fix `unifiedSearch` mock in `SearchBar&#x…
78f8baf 
…60; jest test (#192211) (#192239)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[UII] Fix `unifiedSearch` mock in `SearchBar`
jest test (#192211)](#192211)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jen
Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-06T06:42:47Z","message":"[UII]
Fix `unifiedSearch` mock in `SearchBar` jest test (#192211)\n\n##
Summary\r\n\r\nResolves #181510. Fixes missing method in the mocked
`unifiedSearch`\r\ndependency that was causing flaky test
failures.","sha":"24e1b67027c545176fed8d8b5f8b726d45245181","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.16.0"],"title":"[UII]
Fix `unifiedSearch` mock in `SearchBar` jest
test","number":192211,"url":"https://github.com/elastic/kibana/pull/192211","mergeCommit":{"message":"[UII]
Fix `unifiedSearch` mock in `SearchBar` jest test (#192211)\n\n##
Summary\r\n\r\nResolves #181510. Fixes missing method in the mocked
`unifiedSearch`\r\ndependency that was causing flaky test
failures.","sha":"24e1b67027c545176fed8d8b5f8b726d45245181"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192211","number":192211,"mergeCommit":{"message":"[UII]
Fix `unifiedSearch` mock in `SearchBar` jest test (#192211)\n\n##
Summary\r\n\r\nResolves #181510. Fixes missing method in the mocked
`unifiedSearch`\r\ndependency that was causing flaky test
failures.","sha":"24e1b67027c545176fed8d8b5f8b726d45245181"}}]}]
BACKPORT-->

Co-authored-by: Jen Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jen-huang jen-huang

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[UII] Fix unifiedSearch mock in SearchBar jest test jen-huang/kibana
4 participants
@jen-huang @elasticmachine @criamico @kibanamachine