Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FTR] Refactor SuperTest provider to the kbn-ftr-common-functional-services pkg #191999

Merged
merged 7 commits into from
Sep 5, 2024
Merged

[FTR] Refactor SuperTest provider to the kbn-ftr-common-functional-services pkg #191999

merged 7 commits into from
Sep 5, 2024

Conversation

wayneseymour
Copy link
Member

Move supertest from global folder to specific package.

Resolves: #191970

@wayneseymour wayneseymour added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting FTR labels Sep 3, 2024
@wayneseymour wayneseymour self-assigned this Sep 3, 2024
@wayneseymour
Copy link
Member Author

/ci

@wayneseymour wayneseymour marked this pull request as ready for review September 3, 2024 17:37
@wayneseymour wayneseymour requested review from a team as code owners September 3, 2024 17:37
dominiqueclarke
dominiqueclarke approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obs-ux-management changes LGTM

dmlemeshko
dmlemeshko approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ftr-common-functional-services 69 77 +8
Unknown metric groups

API count

id before after diff
@kbn/ftr-common-functional-services 94 102 +8

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

@wayneseymour wayneseymour merged commit 666ab3d into elastic:main Sep 5, 2024
51 checks passed
@wayneseymour wayneseymour deleted the supertest-pkg branch September 5, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@jbudz jbudz jbudz approved these changes

Assignees

@wayneseymour wayneseymour

Labels
backport:skip This commit does not require backporting ci:all-cypress-suites FTR release_note:skip Skip the PR/issue when compiling release notes v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FTR] Refactor SuperTest provider to the kbn-ftr-common-functional-services pkg
6 participants
@wayneseymour @kibana-ci @jbudz @dmlemeshko @dominiqueclarke @kibanamachine