Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FTR] Refactor SuperTest provider to the kbn-ftr-common-functional-services pkg #191970

Closed
wayneseymour opened this issue Sep 3, 2024 · 0 comments · Fixed by #191999
Closed

[FTR] Refactor SuperTest provider to the kbn-ftr-common-functional-services pkg #191970

wayneseymour opened this issue Sep 3, 2024 · 0 comments · Fixed by #191999
Assignees
@wayneseymour
Labels
FTR needs-team Issues missing a team label

Comments

@wayneseymour
Copy link
Member

wayneseymour commented Sep 3, 2024 •
edited
Loading

Summary

When services have no granular bearing, it's difficult to tell which dependencies are needed where, particularly for reaching a goal of running only subsets of tests.

Next on the list of moving services to packages, is the supertest provider, which follows along this list of refactorings:

Files that make our dependency inversion work (in this PR's context)

test/api_integration/services/index.ts depends on (via es module import) test/common/services/index.ts.
test/common/services/index.ts is and will continue to be the glue between packages/kbn-ftr-common-functional-services && packages/kbn-ftr-common-functional-ui-services and the rest of the repo.

Resolves private ticket within Appex QA
@wayneseymour wayneseymour self-assigned this Sep 3, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 3, 2024
@wayneseymour wayneseymour changed the title [FTR] Refactor SuperTest provider to a kbn package [FTR] Refactor SuperTest provider to the kbn-ftr-common-functional-services pkg Sep 3, 2024
wayneseymour added a commit to wayneseymour/kibana that referenced this issue Sep 3, 2024
@wayneseymour
[FTR] Refactor SuperTest provider to the kbn-ftr-common-functional-se…
33927ac 
…rvices pkg

Resolves: elastic#191970
@wayneseymour wayneseymour mentioned this issue Sep 3, 2024
Merged
wayneseymour added a commit that referenced this issue Sep 5, 2024
@wayneseymour
[FTR] Refactor SuperTest provider to the kbn-ftr-common-functional-se…
666ab3d 
…rvices pkg (#191999)

Move supertest from global folder to specific package.

Resolves: #191970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wayneseymour wayneseymour

Labels
FTR needs-team Issues missing a team label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FTR] Refactor SuperTest provider to the kbn-ftr-common-functional-services pkg wayneseymour/kibana
1 participant
@wayneseymour