[Response Ops][Task Manager] Add bulk update function that directly updates using the esClient
#191760
Conversation
ymao1
force-pushed
the
tm-partial-update
branch
from
09928f5 to
defa6ba
Compare
ymao1
changed the title
esClient
ymao1
added
v8.16.0
release_note:skip
| @@ -302,23 +307,13 @@ export class TaskStore { | |||
| */ | |||
| public async bulkUpdate( | |||
| docs: ConcreteTaskInstance[], | |||
| { validate, excludeLargeFields = false }: BulkUpdateOpts | |||
There was a problem hiding this comment.
these changes were originally made so we could exclude the state and params from being updated in the mget claim strategy but they are not needed anymore since we can do real partial updates through the ES client.
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6900[✅] x-pack/test/task_manager_claimer_mget/config.ts: 100/100 tests passed. |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
| task.status = TaskStatus.Unrecognized; | ||
| tasksToRemoveUpdates.push({ | ||
| id: task.id, | ||
| version: task.version, |
There was a problem hiding this comment.
I think we probably have the seqNum/primaryTerm for these, in docLatestVersions, however I'm guessing you used the version to save from having to create another extremely similar type :-)
I'm wondering, for the removal of unrecognized tasks, maybe we don't even need the version? These docs shouldn't be updated by anyone anyway, except this code to update their status.
There was a problem hiding this comment.
Makes sense to me. Updated in e05a977
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @ymao1 |
Resolves #187704
Summary
Creates a new
bulkPartialUpdatefunction in thetask_storeclass that uses the ES client to perform bulk partial updates instead of the Saved Objects client. Updates the update in themgettask claimer to use this new function.To verify
Run this branch with the
xpack.task_manager.claim_strategy: 'mget'and ensure that all tasks are running as expected.