Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task Manager] Perform true partial updates when claiming and releasing tasks #187704

Closed
3 tasks
mikecote opened this issue Jul 5, 2024 · 1 comment · Fixed by #191760
Closed
3 tasks

[Task Manager] Perform true partial updates when claiming and releasing tasks #187704

mikecote opened this issue Jul 5, 2024 · 1 comment · Fixed by #191760
Assignees
Labels
Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

mikecote commented Jul 5, 2024

When the mget does a bulkUpdate to change task statuses from idle to claiming or running, it uses the task store's bulkUpdate. The bulkUpdate under the hood uses the saved-object repository which recently got changed to support downward-compatible updates (#152807) by performing a get + Kibana side update before calling index. These extra requests add latency to task runtime and load to Elasticsearch that we do not need when rolling upgrades isn't a concern for claiming and releasing tasks.

Requirements

  • Task store supports partial bulk updates that work directly with the Elasticsearch client. Similar to this PoC.
  • Mget task claiming uses the new partial function instead of the current bulkUpdate Similar to this PoC.
  • When updating recurring tasks after running, we use the new partial function to update the task document via the buffered task store
@mikecote mikecote added Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jul 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
3 participants