[ResponseOps][Cases] clear query cache for cases flaky tests #191212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js-jankisalvi
added
Team:ResponseOps
|
/ci |
js-jankisalvi
added
the
release_note:skip
|
/ci |
|
/ci |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
jcger
reviewed
Aug 28, 2024
| let appMockRenderer: AppMockRenderer; | ||
|
|
||
| beforeEach(() => { | ||
| appMockRenderer = createAppMockRenderer(); | ||
| jest.clearAllMocks(); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| appMockRenderer.queryClient.getQueryCache().clear(); |
There was a problem hiding this comment.
Would be nice to have just one appMockRenderer.cleanup function that does everything. If there is something to change there would be just one place to update, wdyt?
There was a problem hiding this comment.
Updated in 904fb11
|
@elasticmachine merge upstream |
adcoelho
approved these changes
Sep 2, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Clear query cache to fix flakiness of jest unit tests in cases plugin.
Checklist