Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/cases/public/components/create - CustomFields renders correctly #178457

Closed
kibanamachine opened this issue Mar 11, 2024 · 14 comments · Fixed by #189478
Closed

Failing test: Jest Tests.x-pack/plugins/cases/public/components/create - CustomFields renders correctly #178457

kibanamachine opened this issue Mar 11, 2024 · 14 comments · Fixed by #189478
Assignees
@adcoelho
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 11, 2024 •
edited
Loading

A test failed on a tracked branch

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at it (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b5c903369a09dc48/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/create/custom_fields.test.tsx:28:3)
    at _dispatchDescribe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b5c903369a09dc48/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:91:26)
    at describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b5c903369a09dc48/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:55:5)
    at Object.describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b5c903369a09dc48/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/create/custom_fields.test.tsx:19:1)
    at Runtime._execModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b5c903369a09dc48/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:1430:24)
    at Runtime._loadModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b5c903369a09dc48/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:1013:12)
    at Runtime.requireModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b5c903369a09dc48/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:873:12)
    at jestAdapter (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b5c903369a09dc48/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:77:13)
    at runTestInternal (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b5c903369a09dc48/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b5c903369a09dc48/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:444:34)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Mar 11, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 11, 2024
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Mar 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 11, 2024
@cnasikas cnasikas added the Feature:Cases Cases feature label Mar 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

mistic added a commit that referenced this issue Jul 25, 2024
@mistic
skip flaky suite (#178457)
579af1b
@mistic
Copy link
Member

mistic commented Jul 25, 2024

Skipped.

main: 579af1b

@adcoelho adcoelho self-assigned this Jul 30, 2024
@adcoelho adcoelho mentioned this issue Jul 30, 2024
Merged
adcoelho added a commit that referenced this issue Jul 31, 2024
@adcoelho
[ResponseOps][Cases] Unskip flaky test (#189478)
3e994ae 
fixes #178457
fixes #187554

## Summary

I think this test was skipped by mistake.

The [failing
build](https://buildkite.com/elastic/kibana-on-merge/builds/42401#018e2f40-5109-4a2a-a877-f0aeed20f20f)
points to
`x-pack/plugins/cases/public/components/create/custom_fields.test.tsx`
but this file does not exist anymore.

[In the commit where the pipeline
failed](https://github.com/elastic/kibana/tree/cd16d03ca9627b21452eff6b72d771318e85557f)
the file
`x-pack/plugins/cases/public/components/create/template.test.tsx` did
not exist.

The `renders correctly` test is **very** different between these two
files so I think there was some mistake here.

Additionally, there is [this skipped
test](#188133) which IMO is the
correct one. I fix that in a different PR.

PS: I kept looking into our flaky test list and I think the same is the
case for #187554 the file skipped there does not match the one in the
failing pipeline and it did not exist at the time of that commit. I
think there was some confusion and time difference between the failing
tests and the tests being skipped. When the tests were skipped the
original file did not exist anymore and prob all custom field related
`renders correctly` tests were skipped indiscriminately 🤷
@kibanamachine kibanamachine reopened this Aug 1, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@cnasikas
Copy link
Member

cnasikas commented Aug 1, 2024

The failure is for x-pack/plugins/cases/public/components/create/template.test.tsx.

@cnasikas cnasikas closed this as completed Aug 1, 2024
@kibanamachine kibanamachine reopened this Aug 2, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

mistic added a commit that referenced this issue Aug 14, 2024
@mistic
skip flaky suite (#178457)
0086039
@mistic
Copy link
Member

mistic commented Aug 14, 2024

Skipped.

main: 0086039

@js-jankisalvi
Copy link
Contributor

Fixed by #191212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adcoelho adcoelho

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ResponseOps][Cases] Unskip flaky test adcoelho/kibana
6 participants
@adcoelho @mistic @cnasikas @elasticmachine @kibanamachine @js-jankisalvi