-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UII] Support integration policies without agent policy references (aka orphaned integration policies) #190649
[UII] Support integration policies without agent policy references (aka orphaned integration policies) #190649
Conversation
…ge agent policies" modal
…ge agent policies" modal
…uang/kibana into feat/orphaned-integration-policies
…ng/editing an integration policy on the policy form
…elected in create/edit integration
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
@kilfoyle I'm not sure what the overall state of docs for reusable integration policies is, but wanted to ping you about this change in case we should document this ability. |
Thanks for the ping, @jen-huang! Docs issue is here and I should get to both this and the reusable integrations policies docs this week (or early next). Btw, thanks a lot for providing the screencaps and so much detail in this and your other PRs! 🙏 It helps me so much not having to track this stuff down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
played around with Elastic Defend integration, adding/removing integrations to agent policies and checked how the @elastic/security-defend-workflows related pages work.
thanks for the modifications, everything looks good! found some weird stuff on our onboarding page, but looks like it wasn't perfect before as well with multiple policy ids, so i created a follow up issue for @elastic/security-defend-workflows team: https://github.com/elastic/security-team/issues/10362
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @jen-huang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the docs! 👍
Summary
Resolves #182220.
This PR allows integration polices to be saved without being added to any agent policies. These integration policies can be considered "orphaned." Through the API, an empty
policy_ids: []
array can be passed during create operations to add it to no agent policies. The same empty array can be passed during update operations to clear it from all previous agent policies. Clearing agent policies references this way will also set the deprecatedpolicy_id
field tonull
.Clearing agent policy references requires the same licensing as the general reusable integration policies feature.
I spotted a bug where removing one or more agent policy references does not bump their revision. Revision was only bumped for only newly added references This has been fixed in this PR as well.
On the UI side, orphaned integration policies can only be discovered on the Integrations details > Policies table:
Agent policies can be unattached in the manage agent policies modal:
Integration policy create/edit form allows agent policies field to be cleared, with a confirmation modal as a heads up to the user. If the user previously had agent policies attached, and is now clearing it, the normal
This action will update the selected agent policies
will be shown:Checklist
Consider interaction with space aware policiesWill be done in [Fleet] Make reusable integration policies and space awareness work together #190727