Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for 'orphaned' integration policies #1261

Closed
kilfoyle opened this issue Aug 19, 2024 · 0 comments · Fixed by #1296
Closed

Add docs for 'orphaned' integration policies #1261

kilfoyle opened this issue Aug 19, 2024 · 0 comments · Fixed by #1296
Assignees

Comments

@kilfoyle
Copy link
Contributor

kilfoyle commented Aug 19, 2024

Code PR: elastic/kibana#190649
Rel: Docs for the Reusable Integration Policies feature in Fleet
Targets 8.16.

@kilfoyle kilfoyle self-assigned this Aug 19, 2024
jen-huang added a commit to elastic/kibana that referenced this issue Aug 28, 2024
…ka orphaned integration policies) (#190649)

## Summary

Resolves #182220.

This PR allows integration polices to be saved without being added to
any agent policies. These integration policies can be considered
"orphaned." Through the API, an empty `policy_ids: []` array can be
passed during create operations to add it to no agent policies. The same
empty array can be passed during update operations to clear it from all
previous agent policies. Clearing agent policies references this way
will also set the deprecated `policy_id` field to `null`.

Clearing agent policy references requires the same licensing as the
general reusable integration policies feature.

I spotted a bug where removing one or more agent policy references does
not bump their revision. Revision was only bumped for only newly added
references This has been fixed in this PR as well.

On the UI side, orphaned integration policies can only be discovered on
the Integrations details > Policies table:

<img width="1388" alt="image"
src="https://github.com/user-attachments/assets/bcaeb4e7-629a-4ce6-81df-a48a997ed85d">


Agent policies can be unattached in the manage agent policies modal:

<img width="1068" alt="image"
src="https://github.com/user-attachments/assets/7efd48a8-1466-48ee-a48d-18cfbcc4a9a6">


Integration policy create/edit form allows agent policies field to be
cleared, with a confirmation modal as a heads up to the user. If the
user previously had agent policies attached, and is now clearing it, the
normal `This action will update the selected agent policies` will be
shown:

<img width="1108" alt="image"
src="https://github.com/user-attachments/assets/1eade1d1-a456-4d2d-a85f-65801ec55857">


### Checklist

- ~~Consider interaction with space aware policies~~ Will be done in
#190727
- [x] Test with integrations that register custom policy editors
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
  - Will be done in elastic/ingest-docs#1261
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant