Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Single Metric viewer: ensure ml node check is consistent and remove flaky test skip #189668

Closed

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Jul 31, 2024

Summary

Related skipped tests: #189537 and #189565

Removed the skipped tests.

Updated the node check for forecasting to be as it was before the change introduced in #188791

Before that change, the forecasting modal only checked node count and did not check lazy node count. That PR added a check for node count.

In this PR, the node count check is going back to what it was prior.

Flaky test runner build: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6657

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 self-assigned this Jul 31, 2024
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner July 31, 2024 18:19
@alvarezmelissa87 alvarezmelissa87 added v8.16.0 :ml release_note:skip Skip the PR/issue when compiling release notes labels Jul 31, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6657

[❌] x-pack/test/functional/apps/ml/permissions/config.ts: 2/30 tests passed.

see run history

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 5, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #56 / aiops log rate analysis with 'kibana_sample_data_logstsdb' kibana sample data logs displays index details
  • [job] [logs] FTR Configs #56 / aiops log rate analysis with 'kibana_sample_data_logstsdb' kibana sample data logs displays index details

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.6MB 4.6MB -46.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 deleted the ml-permissions-test-fix branch September 7, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml release_note:skip Skip the PR/issue when compiling release notes v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants