Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome X-Pack UI Functional Tests - ML permission.x-pack/test/functional/apps/ml/permissions/full_ml_access·ts - machine learning - permissions for user with full ML access with data loaded (ft_ml_poweruser) should display elements on Single Metric Viewer page correctly #189565

Closed
kibanamachine opened this issue Jul 30, 2024 · 5 comments · Fixed by #192737
Closed

Failing test: Chrome X-Pack UI Functional Tests - ML permission.x-pack/test/functional/apps/ml/permissions/full_ml_access·ts - machine learning - permissions for user with full ML access with data loaded (ft_ml_poweruser) should display elements on Single Metric Viewer page correctly #189565

kibanamachine opened this issue Jul 30, 2024 · 5 comments · Fixed by #192737
Assignees
@pheyos
Labels
failed-test A test failure on a tracked branch, potentially flaky-test :ml

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 30, 2024 •
edited
Loading

A test failed on a tracked branch

Error: Expected forecast "run" button to be 'enabled' (got 'disabled')
    at Assertion.assert (expect.js:100:11)
    at Assertion.eql (expect.js:244:8)
    at Object.assertForecastModalRunButtonEnabled (forecast.ts:106:28)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Context.<anonymous> (full_ml_access.ts:289:13)
    at Object.apply (wrap_function.js:73:16) {
  actual: 'false',
  expected: 'true',
  showDiff: true
}

First failure: kibana-on-merge - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jul 30, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 30, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

mistic added a commit that referenced this issue Jul 31, 2024
@mistic
skip flaky suite (#189565)
8333b4c
@mistic
Copy link
Member

mistic commented Jul 31, 2024

Skipped.

main: 8333b4c

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@alvarezmelissa87
Copy link
Contributor

Removed blocker label as functionality is working as expected.

@alvarezmelissa87 alvarezmelissa87 mentioned this issue Jul 31, 2024
Closed
9 tasks
@pheyos pheyos mentioned this issue Sep 12, 2024
Merged
pheyos added a commit that referenced this issue Sep 13, 2024
@pheyos
[ML] Functional tests - stabilize forecast tests (#192737)
e528c8b 
## Summary

This PR stabilizes and re-enables the forecast tests in the ML
permission and results view test suites by waiting for global loading to
finish before checking the forecast `Run` button state.

### Details

I was able to reproduce the original failures by running the test suites
in my local browser with network speed throttled to `3G`: the forecast
modal opened and the `Run` button was disabled during global page
loading, so the enabled check failed. Introducing the global loading
wait fixed the tests for the throttled local runs.

Closes #189565
Closes #189537
Closes #164381
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 13, 2024
@pheyos
[ML] Functional tests - stabilize forecast tests (elastic#192737)
25779b7 
## Summary

This PR stabilizes and re-enables the forecast tests in the ML
permission and results view test suites by waiting for global loading to
finish before checking the forecast `Run` button state.

### Details

I was able to reproduce the original failures by running the test suites
in my local browser with network speed throttled to `3G`: the forecast
modal opened and the `Run` button was disabled during global page
loading, so the enabled check failed. Introducing the global loading
wait fixed the tests for the throttled local runs.

Closes elastic#189565
Closes elastic#189537
Closes elastic#164381

(cherry picked from commit e528c8b)
kibanamachine added a commit that referenced this issue Sep 13, 2024
@kibanamachine @pheyos
[8.x] [ML] Functional tests - stabilize forecast tests (#192737) (#19…
ce00858 
…2861)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Functional tests - stabilize forecast tests
(#192737)](#192737)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Oskamp","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-13T12:48:51Z","message":"[ML]
Functional tests - stabilize forecast tests (#192737)\n\n##
Summary\r\n\r\nThis PR stabilizes and re-enables the forecast tests in
the ML\r\npermission and results view test suites by waiting for global
loading to\r\nfinish before checking the forecast `Run` button
state.\r\n\r\n### Details\r\n\r\nI was able to reproduce the original
failures by running the test suites\r\nin my local browser with network
speed throttled to `3G`: the forecast\r\nmodal opened and the `Run`
button was disabled during global page\r\nloading, so the enabled check
failed. Introducing the global loading\r\nwait fixed the tests for the
throttled local runs.\r\n\r\nCloses #189565\r\nCloses #189537\r\nCloses
#164381","sha":"e528c8bd8e49ec928df8f08a219d7b4df79c81cb","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","Feature:Anomaly
Detection","release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[ML]
Functional tests - stabilize forecast
tests","number":192737,"url":"https://github.com/elastic/kibana/pull/192737","mergeCommit":{"message":"[ML]
Functional tests - stabilize forecast tests (#192737)\n\n##
Summary\r\n\r\nThis PR stabilizes and re-enables the forecast tests in
the ML\r\npermission and results view test suites by waiting for global
loading to\r\nfinish before checking the forecast `Run` button
state.\r\n\r\n### Details\r\n\r\nI was able to reproduce the original
failures by running the test suites\r\nin my local browser with network
speed throttled to `3G`: the forecast\r\nmodal opened and the `Run`
button was disabled during global page\r\nloading, so the enabled check
failed. Introducing the global loading\r\nwait fixed the tests for the
throttled local runs.\r\n\r\nCloses #189565\r\nCloses #189537\r\nCloses
#164381","sha":"e528c8bd8e49ec928df8f08a219d7b4df79c81cb"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192737","number":192737,"mergeCommit":{"message":"[ML]
Functional tests - stabilize forecast tests (#192737)\n\n##
Summary\r\n\r\nThis PR stabilizes and re-enables the forecast tests in
the ML\r\npermission and results view test suites by waiting for global
loading to\r\nfinish before checking the forecast `Run` button
state.\r\n\r\n### Details\r\n\r\nI was able to reproduce the original
failures by running the test suites\r\nin my local browser with network
speed throttled to `3G`: the forecast\r\nmodal opened and the `Run`
button was disabled during global page\r\nloading, so the enabled check
failed. Introducing the global loading\r\nwait fixed the tests for the
throttled local runs.\r\n\r\nCloses #189565\r\nCloses #189537\r\nCloses
#164381","sha":"e528c8bd8e49ec928df8f08a219d7b4df79c81cb"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Oskamp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pheyos pheyos

Labels
failed-test A test failure on a tracked branch, potentially flaky-test :ml
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML] Functional tests - stabilize forecast tests pheyos/kibana
5 participants
@pheyos @mistic @alvarezmelissa87 @elasticmachine @kibanamachine