[Fleet] Fix uninstall package validation accross space #188749

nchaulet · 2024-07-19T13:37:59Z

Summary

That PR fix the logic to disable the uninstall button to work with the space awareness initiative.

Move the logic to disable the uninstall package button server side has the client may not have the permissions to query package policies across all spaces.

GET /.../nginx/{version}?withMetadata=true
{
 "item": {},
 "metadata": {
    "has_policies": true
  }
}

Fix the server side validation to query package policies across all spaces.

How to test

Create multiple space, add a package policy and agents only in one, and try to uninstall a used package from a space where there is no package policy or agents => the UI should be disabled and the API should reject the request.

Work in progress

obltmachine · 2024-07-19T13:38:13Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

nchaulet · 2024-07-19T15:42:46Z

/ci

elasticmachine · 2024-07-19T16:53:53Z

💔 Build Failed

Buildkite Build
Commit: 0943e88

Failed CI Steps

Test Failures

[job] [logs] Fleet Cypress Tests #5 / Add Integration - Real API should install integration without policy
[job] [logs] Fleet Cypress Tests #5 / Add Integration - Real API should install integration without policy
[job] [logs] Fleet Cypress Tests #3 / Assets - Real API for integration with ML and transforms should install integration with ML module & transforms
[job] [logs] Fleet Cypress Tests #3 / Assets - Real API for integration with ML and transforms should install integration with ML module & transforms
[job] [logs] FTR Configs #10 / Cloud Security Posture Test adding Cloud Security Posture Integrations CNVM CNVM AWS On Add Agent modal there should be modal that has Cloud Formation details as well as button that redirects user to Cloud formation page on AWS upon clicking them
[job] [logs] FTR Configs #10 / Cloud Security Posture Test adding Cloud Security Posture Integrations CNVM CNVM AWS On Add Agent modal there should be modal that has Cloud Formation details as well as button that redirects user to Cloud formation page on AWS upon clicking them
[job] [logs] Fleet Cypress Tests #3 / Install unverified package assets should show force install modal if package is unverified
[job] [logs] Fleet Cypress Tests #3 / Install unverified package assets should show force install modal if package is unverified

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`fleet`	1228	1229	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	1.8MB	1.8MB	+130.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`fleet`	72	73	+1

Unknown metric groups

API count

id	before	after	diff
`fleet`	1350	1351	+1

History

cc @nchaulet

nchaulet · 2024-07-19T19:00:43Z

/ci

elasticmachine · 2024-07-19T19:02:58Z

Pinging @elastic/fleet (Team:Fleet)

juliaElastic

LGTM

nchaulet · 2024-07-23T14:37:04Z

@elasticmachine merge upstream

kibana-ci · 2024-07-23T16:01:17Z

💚 Build Succeeded

Buildkite Build
Commit: e3fc43c

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`fleet`	1228	1229	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	1.8MB	1.8MB	+133.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`fleet`	72	73	+1

Unknown metric groups

API count

id	before	after	diff
`fleet`	1350	1351	+1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

* master: (3487 commits) `BedrockChat` & `GeminiChat` (elastic#186809) [ResponseOps] log error when ES Query rules find docs out of time range (elastic#186332) skip flaky suite (elastic#188997) [Security solution][Alert Details] Enable preview feature flag and cypress tests (elastic#188580) [EuiProviders] Warn Developer if EuiProvider is missing (elastic#184608) [Security Solution ] Fixes Timeline infinite loading bug (elastic#188943) Improve SearchSource SearchRequest type (elastic#186862) Deprecate Search Sessions config (elastic#188037) [Synthetics] Add missing monitorType and tag info in cards !! (elastic#188824) [Console Monaco] Resolve uncaught error from tokenizer (elastic#188746) [Data Forge] Add `service.logs` dataset as a data stream (elastic#188786) [Console] Fix failing bulk requests (elastic#188552) Update dependency terser to ^5.31.2 (main) (elastic#188528) [APM][ECO] Telemetry (elastic#188627) [Fleet] Fix uninstall package validation accross space (elastic#188749) Update warning on `xpack.fleet.enableExperimental` (elastic#188917) [DOCS][Cases] Automate more screenshots for cases (elastic#188697) [Fleet] Fix get one agent when feature flag disabled (elastic#188953) chore(investigate): Add investigate-app plugin from poc (elastic#188122) [Monaco Editor] Add Search functionality (elastic#188337) ...

* master: (2400 commits) `BedrockChat` & `GeminiChat` (elastic#186809) [ResponseOps] log error when ES Query rules find docs out of time range (elastic#186332) skip flaky suite (elastic#188997) [Security solution][Alert Details] Enable preview feature flag and cypress tests (elastic#188580) [EuiProviders] Warn Developer if EuiProvider is missing (elastic#184608) [Security Solution ] Fixes Timeline infinite loading bug (elastic#188943) Improve SearchSource SearchRequest type (elastic#186862) Deprecate Search Sessions config (elastic#188037) [Synthetics] Add missing monitorType and tag info in cards !! (elastic#188824) [Console Monaco] Resolve uncaught error from tokenizer (elastic#188746) [Data Forge] Add `service.logs` dataset as a data stream (elastic#188786) [Console] Fix failing bulk requests (elastic#188552) Update dependency terser to ^5.31.2 (main) (elastic#188528) [APM][ECO] Telemetry (elastic#188627) [Fleet] Fix uninstall package validation accross space (elastic#188749) Update warning on `xpack.fleet.enableExperimental` (elastic#188917) [DOCS][Cases] Automate more screenshots for cases (elastic#188697) [Fleet] Fix get one agent when feature flag disabled (elastic#188953) chore(investigate): Add investigate-app plugin from poc (elastic#188122) [Monaco Editor] Add Search functionality (elastic#188337) ...

[Fleet] Fix uninstall package validation accross space

0943e88

nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 19, 2024

nchaulet self-assigned this Jul 19, 2024

nchaulet added 3 commits July 19, 2024 14:07

fix UI

db00999

fix server side validation

a10e0b5

Add api TESTS

e81d02a

nchaulet marked this pull request as ready for review July 19, 2024 19:02

nchaulet requested a review from a team as a code owner July 19, 2024 19:02

juliaElastic approved these changes Jul 22, 2024

View reviewed changes

nchaulet added 3 commits July 22, 2024 20:51

fix tests

e30f91d

fix cypress tests

8d22856

fix typo

de0ba52

Merge branch 'main' into fix-uninstall-accros-space

e3fc43c

nchaulet merged commit f675a8a into elastic:main Jul 23, 2024
22 checks passed

nchaulet deleted the fix-uninstall-accros-space branch July 23, 2024 16:42

kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Jul 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Fix uninstall package validation accross space #188749

[Fleet] Fix uninstall package validation accross space #188749

nchaulet commented Jul 19, 2024 •

edited

Loading

obltmachine commented Jul 19, 2024

nchaulet commented Jul 19, 2024

elasticmachine commented Jul 19, 2024 •

edited

Loading

API count

nchaulet commented Jul 19, 2024

elasticmachine commented Jul 19, 2024

juliaElastic left a comment

nchaulet commented Jul 23, 2024

kibana-ci commented Jul 23, 2024

API count

[Fleet] Fix uninstall package validation accross space #188749

[Fleet] Fix uninstall package validation accross space #188749

Conversation

nchaulet commented Jul 19, 2024 • edited Loading

Summary

How to test

obltmachine commented Jul 19, 2024

🤖 GitHub comments

nchaulet commented Jul 19, 2024

elasticmachine commented Jul 19, 2024 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Public APIs missing comments

Async chunks

Public APIs missing exports

API count

History

nchaulet commented Jul 19, 2024

elasticmachine commented Jul 19, 2024

juliaElastic left a comment

Choose a reason for hiding this comment

nchaulet commented Jul 23, 2024

kibana-ci commented Jul 23, 2024

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Public APIs missing exports

API count

History

nchaulet commented Jul 19, 2024 •

edited

Loading

elasticmachine commented Jul 19, 2024 •

edited

Loading