Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet]: Able to uninstall integration from another space even when assigned to an Agent Policy. #187632

Closed
harshitgupta-qasource opened this issue Jul 5, 2024 · 5 comments · Fixed by #188749
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@harshitgupta-qasource
Copy link

Kibana Build details:

VERSION: 8.15.0 SNAPSHOT
BUILD: 75972
COMMIT: 260882e19521800317c68b29117f649a7b91ee46

Host OS: All

Preconditions:

  1. 8.15.0 SNAPSHOT or above Kibana should be available.
  2. Agent Policy should be created.
  3. Space should be created.

Steps to reproduce:

  1. Log in to the Default Space.
  2. Navigate to the Integrations Tab and search for the Nginx Integration (or any integration).
  3. Install the integration to a selected agent policy.
  4. Now, log in to a newly created space.
  5. Navigate to the Nginx integration overview page and go to the settings tab.
  6. Notice that the Delete Integration button is enabled even though it is assigned to an agent policy. [Observation 1]
  7. Click on Delete button.
  8. Observe that user is able to uninstall integration from another space. [Observation 2]

Expected Result:

  • User should not be able to uninstall integration from another space even when assigned to an Agent Policy.

Screenshot:

  1. Default Space
    image
    image

  2. Newly Created Space
    image

Screen-cast

Nginx.-.Integrations.-.Elastic.Mozilla.Firefox.2024-07-05.12-07-42.mp4

Feature:
#172963

@harshitgupta-qasource harshitgupta-qasource added bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@harshitgupta-qasource
Copy link
Author

@amolnater-qasource Kindly review

@amolnater-qasource
Copy link

Secondary review for this ticket is Done.

@nchaulet nchaulet self-assigned this Jul 19, 2024
@nchaulet
Copy link
Member

That an interesting, we will not be able to disable that button purely client side has we used to do, as the user may not have access to all integration policies.

I think we can introduce a new key metadata in the GET package response

GET /.../nginx/{version}?withMetadata=true
{
 "item": {},
 "metadata": {
    "has_policies": true
  }
}

And disable the uninstall button based on that flag.

We should also make sure the server side validation retrieve policies accross all spaces.

@harshitgupta-qasource
Copy link
Author

harshitgupta-qasource commented Jul 30, 2024

Hi Team

We have re-validated this issue on the latest 8.15.0 BC4 Kibana cloud environment and found it fixed now.

Observations:

  • User is not be able to uninstall integration from another space even when assigned to an Agent Policy.

Build details:
VERSION: 8.15.0
BUILD: 76261
COMMIT: 9d62937

Screen-cast

Nginx.-.Integrations.-.Elastic.Mozilla.Firefox.2024-07-30.14-35-43.mp4

Hence, we are marking this issue as QA: Validated.

Thanks

@harshitgupta-qasource harshitgupta-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants