[ResponseOps] Bring back EuiThemeProvider to fix o11y and stack monitoring rules in stack management #188724

maryam-saeidi · 2024-07-19T09:05:16Z

Related to #186969 and elastic/response-ops-team#218

Summary

This PR brings back EuiThemeProvider to fix o11y and stack monitoring rules in stack management.

To check/do

Add an APM test that fails without this fix
Check if this solves the related SDH for CPU Usage
- Yes, it will solve that issue (comment)
Smoke test ALL rule types in stack management
- Can we load the rule form?
- Can we adjust all the input fields without error?
- Does it work both with and without data in the preview chart?

… stack management

obltmachine · 2024-07-19T09:05:34Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

maryam-saeidi · 2024-07-19T15:07:02Z

x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout.ts

@@ -321,6 +371,19 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
      await discardNewRuleCreation();
    });

+    // Related issue that this test is trying to prevent:
+    // https://github.com/elastic/kibana/issues/186969
+    it('should successfully show the APM error count rule flyout', async () => {


Before the above fix, this test would fail:

Error UI

elasticmachine · 2024-07-19T15:08:03Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

kibana-ci · 2024-07-22T08:18:55Z

💚 Build Succeeded

Buildkite Build
Commit: 5830a25
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-188724-5830a25878a2
Observability Deployment

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.5MB	3.5MB	+872.0B
`triggersActionsUi`	1.7MB	1.7MB	+130.0B
total			+1002.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

crespocarlos · 2024-07-22T08:27:33Z

...s/observability_solution/apm/public/components/alerting/ui_components/popover_expression.tsx

@@ -14,10 +14,11 @@ interface Props {
  value: React.ReactNode;
  children?: React.ReactNode;
  color?: ExpressionColor;
+  dataTestSubj?: string;


I wonder if it would be better to name it data-test-subj instead?

I used dataTestSubj since this is our component not Eui, but I can change it if that's preferred. I also saw dataTestSubj used in other places in APM plugin such as this.

Does it mean when I want to access this prop, I should do something like:

const { title, value, children, color, 'data-test-subj': dataTestSubj } = props;

or

data-test-subj={props['data-test-subj']}

The current implementation seems simpler, IMO.

IMO this attribute should preferably be all in either kebab-case or cameCase, but both conventions are used all over Kibana. My comment was a nit though. Anything you decide will be fine with me.

maryam-saeidi · 2024-07-22T10:44:38Z

@cnasikas I checked all the observability rules in stack management, and they seemed fine (In case of an issue, we still have the option of creating them via observability.)

Regarding stack management rules, most of them had the same issue, and this fix will solve the problem.

Would you mind checking the rest of the rules to make sure they work with this fix?

cnasikas · 2024-07-22T11:22:22Z

Thanks @maryam-saeidi! Yes, we will test the rest of them to be 100% sure that the fix works and does not break the rest of the rules.

kibanamachine · 2024-07-22T13:56:41Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6603

[✅] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts: 100/100 tests passed.
[✅] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/shared/config.ts: 100/100 tests passed.

see run history

elasticmachine · 2024-07-23T07:47:47Z

Pinging @elastic/response-ops (Team:ResponseOps)

cnasikas

I tested all rule types and for each rule type, I interacted with all inputs, charts, and KQL bars. It is working as expected. LGTM!

…oring rules in stack management (elastic#188724) Related to elastic#186969 and elastic/response-ops-team#218 ## Summary This PR brings back EuiThemeProvider to fix o11y and stack monitoring rules in stack management. ## To check/do - [x] Add an APM test that fails without this fix - [x] Check if this solves the related SDH for [CPU Usage](elastic/sdh-kibana#4829) - Yes, it will solve that issue ([comment](elastic/sdh-kibana#4829 (comment))) - [x] Smoke test **ALL** rule types in stack management - Can we load the rule form? - Can we adjust all the input fields without error? - Does it work both with and without data in the preview chart? (cherry picked from commit ed32c98)

kibanamachine · 2024-07-23T08:47:53Z

💚 All backports created successfully

Status	Branch	Result
✅	8.14
✅	8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…k monitoring rules in stack management (#188724) (#188905) # Backport This will backport the following commits from `main` to `8.15`: - [[ResponseOps] Bring back EuiThemeProvider to fix o11y and stack monitoring rules in stack management (#188724)](#188724)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Maryam Saeidi <[email protected]>

…k monitoring rules in stack management (#188724) (#188904) # Backport This will backport the following commits from `main` to `8.14`: - [[ResponseOps] Bring back EuiThemeProvider to fix o11y and stack monitoring rules in stack management (#188724)](#188724)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Maryam Saeidi <[email protected]>

Bring back EuiThemeProvider to fix o11y and stack monitoring rules in…

e83053e

… stack management

maryam-saeidi added release_note:fix v8.15.0 labels Jul 19, 2024

maryam-saeidi self-assigned this Jul 19, 2024

maryam-saeidi added 4 commits July 19, 2024 13:14

Fix prop name

7cace0a

Add a simple apm rule test

4037b50

Change test description

fec9d8d

Add comment

7eaaae5

maryam-saeidi commented Jul 19, 2024

View reviewed changes

maryam-saeidi marked this pull request as ready for review July 19, 2024 15:07

maryam-saeidi requested review from a team as code owners July 19, 2024 15:07

Merge branch 'main' into fix-o11y-rules-in-stack

da3f96e

botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jul 19, 2024

smith added the apm:review label Jul 19, 2024

Merge branch 'main' into fix-o11y-rules-in-stack

5830a25

crespocarlos reviewed Jul 22, 2024

View reviewed changes

maryam-saeidi mentioned this pull request Jul 22, 2024

[OBX-UX-MNGMT][BUG]APM creation rules flyout is broken when it's accessed from Stack Management #186970

Open

crespocarlos approved these changes Jul 23, 2024

View reviewed changes

cnasikas changed the title ~~Bring back EuiThemeProvider to fix o11y and stack monitoring rules in stack management~~ [ResponseOps] Bring back EuiThemeProvider to fix o11y and stack monitoring rules in stack management Jul 23, 2024

cnasikas added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Jul 23, 2024

cnasikas added the v8.16.0 label Jul 23, 2024

cnasikas added the v8.14.4 label Jul 23, 2024

cnasikas approved these changes Jul 23, 2024

View reviewed changes

maryam-saeidi merged commit ed32c98 into elastic:main Jul 23, 2024
31 checks passed

kibanamachine mentioned this pull request Jul 23, 2024

[8.14] [ResponseOps] Bring back EuiThemeProvider to fix o11y and stack monitoring rules in stack management (#188724) #188904

Merged

kibanamachine mentioned this pull request Jul 23, 2024

[8.15] [ResponseOps] Bring back EuiThemeProvider to fix o11y and stack monitoring rules in stack management (#188724) #188905

Merged

maryam-saeidi deleted the fix-o11y-rules-in-stack branch July 23, 2024 09:19

This was referenced Jul 29, 2024

[Response Ops][Rule Form V2] Rule form v2: Actions Modal and Actions Form #187434

Merged

[OBX-UX-MNGMT][BUG] APM creation rules flyout is broken when it's accessed from Stack Management #186969

Closed

maryam-saeidi mentioned this pull request Aug 9, 2024

Unable to add Latency threshold alert rule due to error #187455

Closed

maryam-saeidi mentioned this pull request Aug 23, 2024

[Synthetics TLS certificate] Error when opening the rule's flyout #188828

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ResponseOps] Bring back EuiThemeProvider to fix o11y and stack monitoring rules in stack management #188724

[ResponseOps] Bring back EuiThemeProvider to fix o11y and stack monitoring rules in stack management #188724

maryam-saeidi commented Jul 19, 2024 •

edited by kibanamachine

Loading

obltmachine commented Jul 19, 2024

maryam-saeidi Jul 19, 2024

elasticmachine commented Jul 19, 2024

kibana-ci commented Jul 22, 2024 •

edited

Loading

crespocarlos Jul 22, 2024

maryam-saeidi Jul 22, 2024

maryam-saeidi Jul 22, 2024

crespocarlos Jul 23, 2024

maryam-saeidi commented Jul 22, 2024 •

edited

Loading

cnasikas commented Jul 22, 2024

kibanamachine commented Jul 22, 2024

elasticmachine commented Jul 23, 2024

cnasikas left a comment •

edited

Loading

kibanamachine commented Jul 23, 2024

[ResponseOps] Bring back EuiThemeProvider to fix o11y and stack monitoring rules in stack management #188724

[ResponseOps] Bring back EuiThemeProvider to fix o11y and stack monitoring rules in stack management #188724

Conversation

maryam-saeidi commented Jul 19, 2024 • edited by kibanamachine Loading

Summary

To check/do

obltmachine commented Jul 19, 2024

🤖 GitHub comments

maryam-saeidi Jul 19, 2024

Choose a reason for hiding this comment

elasticmachine commented Jul 19, 2024

kibana-ci commented Jul 22, 2024 • edited Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

History

crespocarlos Jul 22, 2024

Choose a reason for hiding this comment

maryam-saeidi Jul 22, 2024

Choose a reason for hiding this comment

maryam-saeidi Jul 22, 2024

Choose a reason for hiding this comment

crespocarlos Jul 23, 2024

Choose a reason for hiding this comment

maryam-saeidi commented Jul 22, 2024 • edited Loading

cnasikas commented Jul 22, 2024

kibanamachine commented Jul 22, 2024

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6603

elasticmachine commented Jul 23, 2024

cnasikas left a comment • edited Loading

Choose a reason for hiding this comment

kibanamachine commented Jul 23, 2024

💚 All backports created successfully

Questions ?

maryam-saeidi commented Jul 19, 2024 •

edited by kibanamachine

Loading

kibana-ci commented Jul 22, 2024 •

edited

Loading

maryam-saeidi commented Jul 22, 2024 •

edited

Loading

cnasikas left a comment •

edited

Loading