Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified Histogram] Fix metric chart width from 90$ to 90% #188150

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

davismcphee
Copy link
Contributor

Summary

This PR fixes a minor typo from #187981 where the metric chart width is being set to 90$ instead of 90%. Now it's the correct size and doesn't cost 90$ 🙂

Checklist

For maintainers

@davismcphee davismcphee added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jul 11, 2024
@davismcphee davismcphee self-assigned this Jul 11, 2024
@davismcphee
Copy link
Contributor Author

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @davismcphee

@davismcphee davismcphee marked this pull request as ready for review July 11, 2024 20:37
@davismcphee davismcphee requested a review from a team as a code owner July 11, 2024 20:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 90$ less!

@davismcphee davismcphee merged commit 4b9a9d7 into elastic:main Jul 11, 2024
27 checks passed
@davismcphee davismcphee deleted the fix-histogram-metric-width branch July 11, 2024 21:17
@stratoula
Copy link
Contributor

This PR got all wrong from the beginning 🤦 Thanx Davis ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants