[ES|QL] [Unified Histogram] Changes the ratio to be rectangle #187981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
stratoula
added
release_note:skip
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
davismcphee
approved these changes
Jul 10, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
10 tasks
davismcphee
reviewed
Jul 11, 2024
| @@ -197,7 +185,7 @@ export function Histogram({ | |||
| } | |||
|
|
|||
| & .lnsExpressionRenderer { | |||
| width: ${chartSize}; | |||
| width: ${attributes.visualizationType === 'lnsMetric' ? '90$' : '100%'}; | |||
There was a problem hiding this comment.
Oops, looks like the latest changes switched the width from 90% to 90$. I opened a PR to fix it here and promise not to charge 90$ for it: #188150.
davismcphee
added a commit
that referenced
this pull request
Jul 11, 2024
## Summary This PR fixes a minor typo from #187981 where the metric chart width is being set to `90$` instead of `90%`. Now it's the correct size and doesn't cost 90$ 🙂 ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We had a chat with @gvnmagni about the ratio of the metric in Discover. The square one is okeish but not for multi values.
We decided to change it in rectangle to be closer to how it will look in a dashboard