-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rollups] Update rollup badges in Data view form #187235
[Rollups] Update rollup badges in Data view form #187235
Conversation
/ci |
Pinging @elastic/kibana-management (Team:Kibana Management) |
…enaStoeva/kibana into rollups/data-view-form-badges
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @ElenaStoeva |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thanks!
It might be better to change Beta
badge color from the bright pink to a gray color.
defaultMessage="Deprecated" | ||
/> | ||
</EuiBadge> | ||
</RollupDeprecationTooltip> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also update i18n indexPatternEditor.typeSelect.rollup
string on Line 103 with Rollup (deprecated)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @jughosta! Yes, it makes sense to me to rename the rollup option to Rollup (deprecated)
. Regarding changing the Beta badge color to gray, @jovana-andjelkovic do you have any opinion on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with renaming the rollup option as well 👍
@ElenaStoeva Given that we're using gray color for Index in this context, I would avoid using the same for Beta.
I took a look a look at EUI specs and we don't have guidelines on when which version of the Beta badge is used, and it looks like we're not using the designated beta badge here anyways 🤔
Overall, I do see the point in making Beta badge stand out less, but given the usage of Rollups, I would say let's keep the pink color as is.
cc @alisonelizabeth @formgeist @tylerperk - no action needed, just to be aware of changes.
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
cc @ElenaStoeva |
Closes #186663
Summary
Follow-up to #186321. This PR updates the Rollup badges in the Data view create form so that they show that Rollup is deprecated.
Before:
Now:
How to test:
DELETE /mock_rollup_index