-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rollups] Fix functional tests #186103
Merged
ElenaStoeva
merged 3 commits into
elastic:main
from
ElenaStoeva:rollups/fix-functional-tests
Jun 13, 2024
Merged
[Rollups] Fix functional tests #186103
ElenaStoeva
merged 3 commits into
elastic:main
from
ElenaStoeva:rollups/fix-functional-tests
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElenaStoeva
added
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
release_note:skip
Skip the PR/issue when compiling release notes
Feature:Rollups
labels
Jun 12, 2024
Pinging @elastic/kibana-management (Team:Kibana Management) |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6298[❌] x-pack/test/functional/apps/rollup_job/config.ts: 0/200 tests passed. |
6 tasks
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @ElenaStoeva |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6316[✅] x-pack/test/functional/apps/rollup_job/config.ts: 200/200 tests passed. |
yuliacech
approved these changes
Jun 13, 2024
kibanamachine
added
v8.15.0
backport:skip
This commit does not require backporting
labels
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
Feature:Rollups
release_note:skip
Skip the PR/issue when compiling release notes
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183975
Fixes #183976
Fixes #183925
Fixes #183926
Fixes #183927
Fixes #104569
Fixes #56816
Fixes #168267
Summary
This PR fixes the failing Rollup functional tests. The reason for the failures is that, since 8.15, Es doesn't allow creating a new rollup job if there is no existing rollup usage in the cluster, where rollup usage is considered rollup jobs or rollup indices. To fix the tests, we create a mock rollup index which essentially is an index that has a
_meta
mappings property with rollup information.Flaky test runner build x200: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6316