-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Update grammars #186013
[ES|QL] Update grammars #186013
Conversation
Pinging @elastic/kibana-esql (Team:ESQL) |
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Page load bundle
HistoryTo update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker for this PR, but there seems to be a lot of overlap between
esql_generate_function_definitions.sh
esql_generate_function_docs.sh
esql_grammar_sync.sh
Are you intending to extract the common parts to make maintaining these scripts easier?
@@ -17,3 +17,12 @@ steps: | |||
provider: gcp | |||
machineType: n2-standard-2 | |||
preemptible: true | |||
- command: .buildkite/scripts/steps/esql_generate_function_docs.sh | |||
label: Generate Function Definitions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
label: Generate Function Definitions | |
label: Generate Function Docs |
@@ -17,3 +17,12 @@ steps: | |||
provider: gcp | |||
machineType: n2-standard-2 | |||
preemptible: true | |||
- command: .buildkite/scripts/steps/esql_generate_function_docs.sh | |||
label: Generate Function Definitions | |||
timeout_in_minutes: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can bump these timeouts a bit higher. Generate Function Definitions
is at 8-9 minutes runtime.
This PR updates the ES|QL grammars (lexer and parser) to match the latest version in Elasticsearch.