Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Update grammars #186013

Closed
wants to merge 3 commits into from
Closed

Conversation

kibanamachine
Copy link
Contributor

This PR updates the ES|QL grammars (lexer and parser) to match the latest version in Elasticsearch.

@kibanamachine kibanamachine requested a review from a team as a code owner June 11, 2024 17:24
@kibanamachine kibanamachine added the release_note:skip Skip the PR/issue when compiling release notes label Jun 11, 2024
@kibanamachine kibanamachine requested a review from a team as a code owner June 11, 2024 17:24
@kibanamachine kibanamachine added the Team:ESQL ES|QL related features in Kibana label Jun 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 11, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #16 / validation logic Full validation performed dissect from a_index | dissect => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed dissect from a_index | dissect => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed dissect from a_index | dissect stringField "%{firstWord}" option = => 2 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed dissect from a_index | dissect stringField "%{firstWord}" option = => 2 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed eval from a_index | eval => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed eval from a_index | eval => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed eval from a_index | eval *+ numberField => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed eval from a_index | eval *+ numberField => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed eval from a_index | eval /+ numberField => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed eval from a_index | eval /+ numberField => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed eval from a_index | eval %+ numberField => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed eval from a_index | eval %+ numberField => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed eval from a_index | eval a=b, => 2 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed eval from a_index | eval a=b, => 2 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed eval from a_index | eval a=round(numberField), => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed eval from a_index | eval a=round(numberField), => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed eval from a_index | eval in => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed eval from a_index | eval in => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed eval from a_index | eval not => 2 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed eval from a_index | eval not => 2 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed grok from a_index | grok => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed grok from a_index | grok => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed row row => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed row row => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed row row var = 1 in ( => 2 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed row row var = 1 in ( => 2 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed sort from a_index | sort => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed sort from a_index | sort => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed stats from a_index | stats by => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed stats from a_index | stats by => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed stats from a_index | stats numberField= => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed stats from a_index | stats numberField= => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed stats from a_index | stats numberField=5 by => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed stats from a_index | stats numberField=5 by => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed where from a_index | where *+ numberField => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed where from a_index | where *+ numberField => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed where from a_index | where /+ numberField => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed where from a_index | where /+ numberField => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed where from a_index | where %+ numberField => 1 errors, 0 warnings
  • [job] [logs] Jest Tests #16 / validation logic Full validation performed where from a_index | where %+ numberField => 1 errors, 0 warnings

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.2MB 3.2MB +2.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@Ikuni17 Ikuni17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker for this PR, but there seems to be a lot of overlap between

esql_generate_function_definitions.sh
esql_generate_function_docs.sh
esql_grammar_sync.sh

Are you intending to extract the common parts to make maintaining these scripts easier?

@@ -17,3 +17,12 @@ steps:
provider: gcp
machineType: n2-standard-2
preemptible: true
- command: .buildkite/scripts/steps/esql_generate_function_docs.sh
label: Generate Function Definitions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label: Generate Function Definitions
label: Generate Function Docs

@@ -17,3 +17,12 @@ steps:
provider: gcp
machineType: n2-standard-2
preemptible: true
- command: .buildkite/scripts/steps/esql_generate_function_docs.sh
label: Generate Function Definitions
timeout_in_minutes: 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can bump these timeouts a bit higher. Generate Function Definitions is at 8-9 minutes runtime.

@drewdaemon
Copy link
Contributor

Just a test. @Ikuni17 take a look at #186011 for the actual pipeline changes

@drewdaemon drewdaemon closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants