[ES|QL] add docs step to sync pipeline #186011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
/ci |
drewdaemon
added
release_note:skip
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
reviewed
Jun 12, 2024
stratoula
approved these changes
Jun 12, 2024
delanni
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Wouldn't it make sense to merge this with the esql_generate_function_definitions.sh? They're doing a lot of similar things besides the exact generation - and I don't know the background to this, but maybe the docs & functions are often updated together, so why not generate them in a single step & single PR?
|
This is a good point but @drewdaemon knows better |
|
@delanni good idea. I'll make this change. |
delanni
approved these changes
Jun 12, 2024
|
Niiiiice |
|
@elasticmachine merge upstream |
…stic/kibana into operationalize-docs-generator-script
|
Geez... the i18n check takes forever |
|
Going to increase the timeout until #185035 lands |
mistic
approved these changes
Jun 12, 2024
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.15.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#184689 added a script to gather ES|QL function docs from Elasticsearch.
This PR adds it to our CI pipeline!
Close #173492
Close #173817