-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra] Add the logs tab to container views #184854
Merged
jennypavlova
merged 3 commits into
elastic:main
from
jennypavlova:184770-infra-add-logs-tab-to-container-views
Jun 10, 2024
Merged
[Infra] Add the logs tab to container views #184854
jennypavlova
merged 3 commits into
elastic:main
from
jennypavlova:184770-infra-add-logs-tab-to-container-views
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypavlova
added
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
labels
Jun 5, 2024
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jennypavlova
changed the title
[Infra ]Add the logs tab to container views
[Infra] Add the logs tab to container views
Jun 5, 2024
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
Create an Observability project
label
Jun 6, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
crespocarlos
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
ci:project-deploy-observability
Create an Observability project
release_note:skip
Skip the PR/issue when compiling release notes
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #184770
Summary
This PR adds the logs tab to container views.
Testing
Screen.Recording.2024-06-05.at.14.20.11.mov
container.id
can be added and used in inventory to find a container with logs ( This should be added for the docker containers on edge soon - for now it can be checked for a non-docker container )Example with a container id (with logs)