Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Add Logs tab to container views #184770

Closed
Tracked by #179844
jennypavlova opened this issue Jun 4, 2024 · 1 comment · Fixed by #184854
Closed
Tracked by #179844

[Infra] Add Logs tab to container views #184770

jennypavlova opened this issue Jun 4, 2024 · 1 comment · Fixed by #184854
Assignees
@jennypavlova
Labels
enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@jennypavlova
Copy link
Member

jennypavlova commented Jun 4, 2024 •
edited
Loading

Similar to hosts view we want to add the logs tab to the containers views

Image

AC:

  • Add logs tab to the asset details flyout for containers
  • Add logs tab to the asset details page for containers
  • The search bar and table should look like in host view
  • The link and the table should use container.id as filter
@jennypavlova jennypavlova added enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jun 4, 2024
@jennypavlova jennypavlova self-assigned this Jun 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

This was referenced Jun 5, 2024
Merged
Closed
jennypavlova added a commit that referenced this issue Jun 10, 2024
@jennypavlova
[Infra] Add the logs tab to container views (#184854)
2d3dc3f 
Closes #184770 

## Summary

This PR adds the logs tab to container views.

### Testing

- Enable Container view from Infra settings
- Go to Inventory and select Docker Containers from the "Show" drop-down
- Click on a container
   - The logs tab should be visible 
- Click on the Logs tab
- The search functionality and the link (with the filter) should work


![image](https://github.com/elastic/kibana/assets/14139027/c0720a47-50e5-4244-9f50-53882fc5ed53)

- Click on "Open as Page"
   - The logs tab should be visible 
- The search functionality and the link (with the filter) should work

<img width="1717" alt="image"
src="https://github.com/elastic/kibana/assets/14139027/90161dd7-ae66-4274-bc99-39e4c9233fa7">



https://github.com/elastic/kibana/assets/14139027/0ce5761c-cc39-4d55-87ba-a6c12cc7315c

- ⚠️ If some of the containers on the edge cluster don't have logs in
the logs settings the `container.id` can be added and used in inventory
to find a container with logs ( This should be added for the docker
containers on edge soon - for now it can be checked for a non-docker
container )


![image](https://github.com/elastic/kibana/assets/14139027/90d7f0e4-384d-4cc8-aea0-6ff10713450d)

Example with a container id (with logs)


![image](https://github.com/elastic/kibana/assets/14139027/162f37ce-8ba8-4c8d-835d-f2d23c3bc0ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennypavlova jennypavlova

Labels
enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Infra] Add the logs tab to container views jennypavlova/kibana
2 participants
@jennypavlova @elasticmachine