Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable value list modal #181593

Merged
merged 6 commits into from
May 1, 2024
Merged

Enable value list modal #181593

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
00368fd
Enable value list modal
nkhristinin Apr 24, 2024
85fcec2
Merge branch 'main' into enable-value-list-moadl
kibanamachine Apr 24, 2024
93a9223
Merge branch 'main' into enable-value-list-moadl
kibanamachine Apr 29, 2024
30ec089
Merge branch 'main' into enable-value-list-moadl
kibanamachine May 1, 2024
9767318
enable in ServerlessMKI
nkhristinin May 1, 2024
d0258b1
Merge branch 'main' into enable-value-list-moadl
kibanamachine May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/common/experimental_features.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ export const allowedExperimentalValues = Object.freeze({
/**
* Enables the new modal for the value list items
*/
valueListItemsModalEnabled: false,
valueListItemsModalEnabled: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should test be unskipped in Serverless MKI and FF removed?

https://github.com/elastic/kibana/blob/main/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/value_lists/value_list_items.cy.ts#L46-L55

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point!

});

type ExperimentalConfigKeys = Array<keyof ExperimentalFeatures>;
Expand Down