Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable value list modal #181593

Merged
merged 6 commits into from
May 1, 2024
Merged

Enable value list modal #181593

merged 6 commits into from
May 1, 2024

Conversation

nkhristinin
Copy link
Contributor

@nkhristinin nkhristinin commented Apr 24, 2024 •
edited by kibanamachine
Loading

Enable value list modal

@nkhristinin nkhristinin added release_note:skip Skip the PR/issue when compiling release notes ci:cloud-deploy Create or update a Cloud deployment labels Apr 24, 2024
@nkhristinin nkhristinin marked this pull request as ready for review April 24, 2024 15:34
@nkhristinin nkhristinin requested a review from a team as a code owner April 24, 2024 15:34
@nkhristinin nkhristinin added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Apr 24, 2024
@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

vitaliidm
vitaliidm reviewed May 1, 2024
View reviewed changes
x-pack/plugins/security_solution/common/experimental_features.ts
@@ -260,7 +260,7 @@ export const allowedExperimentalValues = Object.freeze({
/**
* Enables the new modal for the value list items
*/
valueListItemsModalEnabled: false,
valueListItemsModalEnabled: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should test be unskipped in Serverless MKI and FF removed?

https://github.com/elastic/kibana/blob/main/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/value_lists/value_list_items.cy.ts#L46-L55

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point!

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin nkhristinin requested a review from a team as a code owner May 1, 2024 10:28
@nkhristinin nkhristinin requested a review from e40pud May 1, 2024 10:28
@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 1, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nkhristinin nkhristinin merged commit 813741f into elastic:main May 1, 2024
36 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 1, 2024
@nkhristinin
Enable value list modal (elastic#181593)
554fc1b 
## Enable value list modal

---------

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 813741f)
@kibanamachine kibanamachine mentioned this pull request May 1, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 1, 2024
@kibanamachine @nkhristinin
[8.14] Enable value list modal (#181593) (#182285)
4c06b87 
# Backport

This will backport the following commits from `main` to `8.14`:
- [Enable value list modal
(#181593)](#181593)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Khristinin
Nikita","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-05-01T18:58:10Z","message":"Enable
value list modal (#181593)\n\n## Enable value list
modal\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"813741f2dfcce6d62faad10231bcf69ae6d7ffff","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","ci:cloud-deploy","v8.15.0"],"title":"Enable
value list
modal","number":181593,"url":"https://github.com/elastic/kibana/pull/181593","mergeCommit":{"message":"Enable
value list modal (#181593)\n\n## Enable value list
modal\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"813741f2dfcce6d62faad10231bcf69ae6d7ffff"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181593","number":181593,"mergeCommit":{"message":"Enable
value list modal (#181593)\n\n## Enable value list
modal\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"813741f2dfcce6d62faad10231bcf69ae6d7ffff"}}]}]
BACKPORT-->

Co-authored-by: Khristinin Nikita <[email protected]>
TinLe added a commit to TinLe/kibana that referenced this pull request May 1, 2024
@TinLe
Merge branch 'master' into dependabot/npm_and_yarn/nodemailer-6.9.9
56f9aa4 
* master: (1654 commits)
  Bump ejs from 3.1.9 to 3.1.10
  Don't render exceptions flyout if data is loading (elastic#181588)
  Enable value list modal (elastic#181593)
  skip flaky suite (elastic#181777)
  skip failing test suite (elastic#182263)
  [Mappings Editor] Disable _source field in serverless (elastic#181712)
  [data.search] Fix unhandled promise rejections (elastic#181785)
  [Fleet] Fix logic for detecting first time Elastic Agent users (elastic#182214)
  [ML] Decouple data_visualizer from MapEmbeddable (elastic#181928)
  [ES|QL] Sorting accepts expressions (elastic#181916)
  [ML] Single Metric Viewer: ensures chart displays correctly when opening from a job annotation (elastic#182176)
  Adding optional Description field to Roles APIs (elastic#182039)
  Upgrade Markdown-it to 14.1.0 (elastic#182244)
  Bump xml-crypto from 5.0.0 to 6.0.0
  [DOCS] Fix docs and screenshots for rule creation changes (elastic#181925)
  Update dependency elastic-apm-node to ^4.5.3 (main) (elastic#182236)
  [Obs AI Assistant] register alert details context in observability plugin (elastic#181501)
  Add `@typescript-eslint/no-floating-promises` (elastic#181456)
  [Playground] Propagate Error message into FE (elastic#182201)
  [ES|QL] Rename the setting to a more generic one and move to the general section (elastic#182074)
  ...
@szaffarano szaffarano mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaliidm vitaliidm vitaliidm approved these changes

@e40pud e40pud Awaiting requested review from e40pud e40pud is a code owner automatically assigned from elastic/security-detection-engine

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes v8.14.0 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nkhristinin @kibana-ci @kibanamachine @vitaliidm