Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK][Security Serverless]: Add semantic headings to Get Started page #181494

Merged
merged 7 commits into from
Apr 29, 2024
Merged

[TASK][Security Serverless]: Add semantic headings to Get Started page #181494

merged 7 commits into from
Apr 29, 2024

Conversation

1Copenut
Copy link
Contributor

@1Copenut 1Copenut commented Apr 23, 2024

Summary

I refactored the Security Serverless "Getting Started" page to use semantic headings instead of P and SPAN tags marked up as headings. This improves the experience for screen reader users and helps us improve our standing against WCAG SC 1.3.1 - Info and Relationships (Level A). Screenshot attached below.

--
Screenshot 2024-04-23 at 3 01 57 PM

Related issues

Please see the related issue link below. This issue originated from an accessibility review of the Security Serverless project.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@1Copenut 1Copenut added WCAG A release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. accessibility: cognition Accessibility issues including cognition, awareness, understanding v8.15.0 labels Apr 23, 2024
@1Copenut 1Copenut self-assigned this Apr 23, 2024
@1Copenut
Copy link
Contributor Author

Buildkite test this

@1Copenut 1Copenut marked this pull request as ready for review April 25, 2024 15:40
@1Copenut 1Copenut requested a review from a team as a code owner April 25, 2024 15:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@1Copenut
Copy link
Contributor Author

Buildkite test this

Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement, LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #12 / dashboard app - group 1 dashboard embeddable data grid are added when a cell filter is clicked

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.7MB 13.7MB +198.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @1Copenut

@1Copenut
Copy link
Contributor Author

I ran the Flaky Test runner for 10 instances on FTR group 12. All instances passed, so going to merge this item.

@1Copenut 1Copenut merged commit 3e7f11b into elastic:main Apr 29, 2024
36 checks passed
@1Copenut 1Copenut deleted the tpierce/8931-get-started-headings branch April 29, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility: cognition Accessibility issues including cognition, awareness, understanding backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0 WCAG A
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants