Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APM OpenAPI spec #180096

Merged
merged 8 commits into from
Apr 9, 2024
Merged

Add APM OpenAPI spec #180096

merged 8 commits into from
Apr 9, 2024

Conversation

smith
Copy link
Contributor

@smith smith commented Apr 4, 2024

Add a YAML OpenAPI spec for some of the APM APIs.

This spec was artisanally crafted by @sorenlouv and previously published https://gist.github.com/sorenlouv/19fb1ffc0b7552fb41b193462d6ee9db. It has been copied here to fulfill some requirements for https://github.com/elastic/docs-projects/issues/175.

We will prioritize the existing issue #129061 to replace the contents with automatically-generated and complete specs.

@smith smith added backport:skip This commit does not require backporting skip-ci labels Apr 4, 2024
@smith smith requested a review from a team as a code owner April 4, 2024 21:58
@botelastic botelastic bot added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Apr 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@smith smith added release_note:skip Skip the PR/issue when compiling release notes technical debt Improvement of the software architecture and operational architecture labels Apr 4, 2024
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few notes, but since it's going to be replaced with automatically-generated content, most of it should be fine when that happens.

I wonder if we'll use something like tsoa to generate the openapi spec. I hope the solution also provides examples of usage.

enum:
- event:write
- config_agent:read
responses:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This endpoint also returns 400 and 403. Should we doc that too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at this time. These specs are incomplete and we're going to be updating them.

type: string

responses:
'200':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also responds with 404

schema:
type: string
responses:
"200":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems to return 500 when business logic error happens - should be 400 though.

@smith smith enabled auto-merge (squash) April 5, 2024 20:30
@mistic mistic disabled auto-merge April 9, 2024 13:30
@mistic mistic merged commit 8a21129 into elastic:main Apr 9, 2024
4 checks passed
@smith smith deleted the nls/openapi branch April 9, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes skip-ci Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants