-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add APM OpenAPI spec #180096
Add APM OpenAPI spec #180096
Conversation
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few notes, but since it's going to be replaced with automatically-generated content, most of it should be fine when that happens.
I wonder if we'll use something like tsoa to generate the openapi spec. I hope the solution also provides examples of usage.
enum: | ||
- event:write | ||
- config_agent:read | ||
responses: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This endpoint also returns 400 and 403. Should we doc that too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not at this time. These specs are incomplete and we're going to be updating them.
type: string | ||
|
||
responses: | ||
'200': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also responds with 404
schema: | ||
type: string | ||
responses: | ||
"200": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one seems to return 500 when business logic error happens - should be 400 though.
Add a YAML OpenAPI spec for some of the APM APIs.
This spec was artisanally crafted by @sorenlouv and previously published https://gist.github.com/sorenlouv/19fb1ffc0b7552fb41b193462d6ee9db. It has been copied here to fulfill some requirements for https://github.com/elastic/docs-projects/issues/175.
We will prioritize the existing issue #129061 to replace the contents with automatically-generated and complete specs.