Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Add documentation for APM APIs #129061

Open
dannycroft opened this issue Mar 31, 2022 · 6 comments
Open

[APM] Add documentation for APM APIs #129061

dannycroft opened this issue Mar 31, 2022 · 6 comments
Assignees
Labels
documentation needs-refinement A reason and acceptance criteria need to be defined for this issue Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture

Comments

@dannycroft
Copy link

dannycroft commented Mar 31, 2022

In order to provide users with the best and most accurate documentation, all APM app API endpoints must be documented with the OpenAPI specification.

Initial support was added in #180096, but these are manually generated and incomplete.

We should probably stay as close as possible to the implementation for the SLO APIs: https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability_solution/slo/docs/openapi/slo

Consult with @elastic/obs-ux-management-team to determine observability standards for generating, maintaining, and publishing OpenAPI specs.

✅ Acceptance criteria

  • Steps to find and add OpenAPI documentation to a public Kibana API in observability are published (undecided: where? In the observability_solution plugin maybe?)
  • APM app API documentation is complete and accurate for all endpoints
  • Steps for updating documentation are published (ideally we would want everything automatically updated when we changed the code, but that's not required initially as long as process to update docs is documented and straightforward)
  • Notify docs team about availability of specs (@smith is tracking the internal issue to do this)
@dannycroft dannycroft added the Team:APM All issues that need APM UI Team support label Mar 31, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@dannycroft dannycroft changed the title Add documentation APM APIs [APM] Add documentation APM APIs Apr 4, 2022
@jasonrhodes
Copy link
Member

+1 I want this too

@dannycroft dannycroft changed the title [APM] Add documentation APM APIs [APM] Add documentation for APM APIs May 3, 2022
@dannycroft dannycroft added the technical debt Improvement of the software architecture and operational architecture label May 3, 2022
@smith smith added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Apr 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@smith smith added needs-refinement A reason and acceptance criteria need to be defined for this issue and removed Team:APM All issues that need APM UI Team support labels Apr 8, 2024
mistic pushed a commit that referenced this issue Apr 9, 2024
Add a YAML OpenAPI spec for some of the [APM
APIs](https://www.elastic.co/guide/en/kibana/current/apm-api.html).

This spec was artisanally crafted by @sorenlouv and previously published
https://gist.github.com/sorenlouv/19fb1ffc0b7552fb41b193462d6ee9db. It
has been copied here to fulfill some requirements for
elastic/docs-projects#175.

We will prioritize the existing issue
#129061 to replace the contents
with automatically-generated and complete specs.
@smith
Copy link
Contributor

smith commented May 15, 2024

The Kibana team has provided guidance and tooling for OpenAPI docs: https://groups.google.com/a/elastic.co/g/kibana-contributors/c/sQunk3FUzA0/m/B1Olq4RhAAAJ?utm_medium=email&utm_source=footer

We might have to consider whether what's provided there will work best with the way we use io-ts, etc., but let's begin the discussion by looking at what they've started.

@jasonrhodes
Copy link
Member

Hey @smith -- this is something @maryam-saeidi has been looking into. She'll work with @miltonhultgren who is helping lead the "low level API guidelines" effort via https://docs.google.com/document/d/12AL5ItHs3L9qrWAvIewkvSFJjnly6kOOVhWOVPESSyY/edit

@maryam-saeidi
Copy link
Member

FYI, related investigation: OpenAPI Specification (OAS) in Observability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation needs-refinement A reason and acceptance criteria need to be defined for this issue Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

7 participants