Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset quality] Awaiting table to be loaded before checking rows #179440

Merged
merged 2 commits into from
Mar 27, 2024
Merged

[Dataset quality] Awaiting table to be loaded before checking rows #179440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a67e1c
Awaiting table to be loaded for checking rows
yngrdyn Mar 26, 2024
de3e8f2
Using cssSelector instead of testSubject selector
yngrdyn Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/dataset_quality/dataset_quality_table_filters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
const testSubjects = getService('testSubjects');
const to = '2024-01-01T12:00:00.000Z';

// FLAKY: https://github.com/elastic/kibana/issues/179092
describe.skip('Dataset quality table filters', () => {
describe('Dataset quality table filters', () => {
before(async () => {
await synthtrace.index(getInitialTestLogs({ to, count: 4 }));
await PageObjects.datasetQuality.navigateTo();
Expand Down
5 changes: 5 additions & 0 deletions x-pack/test/functional/page_objects/dataset_quality.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,10 @@ export function DatasetQualityPageObject({ getPageObjects, getService }: FtrProv
);
},

async waitUntilTableLoaded() {
await find.waitForDeletedByCssSelector('.euiBasicTable-loading');
},

async waitUntilSummaryPanelLoaded() {
await testSubjects.missingOrFail(`datasetQuality-${texts.activeDatasets}-loading`);
await testSubjects.missingOrFail(`datasetQuality-${texts.estimatedData}-loading`);
Expand Down Expand Up @@ -151,6 +155,7 @@ export function DatasetQualityPageObject({ getPageObjects, getService }: FtrProv
},

async getDatasetTableRows(): Promise<WebElementWrapper[]> {
await this.waitUntilTableLoaded();
const table = await testSubjects.find(testSubjectSelectors.datasetQualityTable);
const tBody = await table.findByTagName('tbody');
return tBody.findAllByTagName('tr');
Expand Down
3 changes: 1 addition & 2 deletions ...ess/functional/test_suites/observability/dataset_quality/dataset_quality_table_filters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const to = '2024-01-01T12:00:00.000Z';

// FLAKY: https://github.com/elastic/kibana/issues/178652
describe.skip('Dataset quality table filters', () => {
describe('Dataset quality table filters', () => {
before(async () => {
await synthtrace.index(getInitialTestLogs({ to, count: 4 }));
await PageObjects.svlCommonPage.loginWithRole('admin');
Expand Down