Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset quality] Awaiting table to be loaded before checking rows #179440

Merged

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Mar 26, 2024

Closes #179092 and #178652.

Not awaiting for the loading state to be false produce some flakiness because the request could be slower some times, this PR adds the awaiting when getting table rows.

Flaky test runner (50 times)

@yngrdyn yngrdyn self-assigned this Mar 26, 2024
@yngrdyn yngrdyn requested a review from a team as a code owner March 26, 2024 14:29
@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Mar 26, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn force-pushed the 178652-flaky-dataset-quality-table-filters branch 2 times, most recently from f096b3c to 3af46c1 Compare March 26, 2024 14:49
@yngrdyn yngrdyn force-pushed the 178652-flaky-dataset-quality-table-filters branch from 3af46c1 to 3a67e1c Compare March 26, 2024 15:41
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #90 / Journey[tags_listing_page] Delete tag

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yngrdyn

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's try this

@yngrdyn yngrdyn merged commit cb40ad3 into elastic:main Mar 27, 2024
18 checks passed
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Mar 27, 2024
@gbamparop gbamparop added the Team:obs-ux-logs Observability Logs User Experience Team label Apr 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Dataset Health release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.14.0
Projects
None yet
7 participants