-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataset quality] Awaiting table to be loaded before checking rows #179440
Merged
yngrdyn
merged 2 commits into
elastic:main
from
yngrdyn:178652-flaky-dataset-quality-table-filters
Mar 27, 2024
Merged
[Dataset quality] Awaiting table to be loaded before checking rows #179440
yngrdyn
merged 2 commits into
elastic:main
from
yngrdyn:178652-flaky-dataset-quality-table-filters
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngrdyn
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Mar 26, 2024
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
yngrdyn
force-pushed
the
178652-flaky-dataset-quality-table-filters
branch
2 times, most recently
from
March 26, 2024 14:49
f096b3c
to
3af46c1
Compare
flash1293
reviewed
Mar 26, 2024
...erless/functional/test_suites/observability/dataset_quality/dataset_quality_table_filters.ts
Outdated
Show resolved
Hide resolved
yngrdyn
force-pushed
the
178652-flaky-dataset-quality-table-filters
branch
from
March 26, 2024 15:41
3af46c1
to
3a67e1c
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
To update your PR or re-run it, just comment with: cc @yngrdyn |
flash1293
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's try this
kibanamachine
added
v8.14.0
backport:skip
This commit does not require backporting
labels
Mar 27, 2024
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
Feature:Dataset Health
release_note:skip
Skip the PR/issue when compiling release notes
Team:obs-ux-logs
Observability Logs User Experience Team
v8.14.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #179092 and #178652.
Not awaiting for the loading state to be false produce some flakiness because the request could be slower some times, this PR adds the awaiting when getting table rows.
Flaky test runner (50 times)