Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Update embed mode tests #179171

Merged
merged 7 commits into from
Mar 22, 2024
Merged

[Dashboard] Update embed mode tests #179171

merged 7 commits into from
Mar 22, 2024

Conversation

Heenawter
Copy link
Contributor

@Heenawter Heenawter commented Mar 21, 2024 •
edited
Loading

Part of #176882

Summary

Due to a chrome update in the CI environment, screenshot tests started failing and were skipped - this PR updates the embed mode baseline screenshots so that the failing tests can be unskipped.

Checklist

For maintainers

@Heenawter
Copy link
Contributor Author

/ci

@Heenawter
Copy link
Contributor Author

/ci

@Heenawter
Copy link
Contributor Author

/ci

@Heenawter
Copy link
Contributor Author

/ci

@Heenawter
Copy link
Contributor Author

/ci

@Heenawter Heenawter added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. impact:critical This issue should be addressed immediately due to a critical level of impact on the product. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Mar 22, 2024
@Heenawter Heenawter marked this pull request as ready for review March 22, 2024 15:49
@Heenawter Heenawter requested a review from a team as a code owner March 22, 2024 15:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

nreese
nreese approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review only

@Heenawter Heenawter enabled auto-merge (squash) March 22, 2024 15:55
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Heenawter Heenawter merged commit 2f24c45 into elastic:main Mar 22, 2024
16 checks passed
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Mar 22, 2024
@thomheymann thomheymann mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Heenawter @elasticmachine @kibana-ci @nreese @kibanamachine