Skip to content

Commit

Permalink
[Dashboard] Update embed mode tests (#179171)
Browse files Browse the repository at this point in the history
Part of #176882

## Summary

Due to a chrome update in the CI environment, screenshot tests started
failing and were skipped - this PR updates the embed mode baseline
screenshots so that the failing tests can be unskipped.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
  • Loading branch information
Heenawter authored Mar 22, 2024
1 parent 3a16585 commit 2f24c45
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions test/functional/apps/dashboard/group5/embed_mode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ export default function ({
const screenshot = getService('screenshots');
const log = getService('log');

// Failing: See https://github.com/elastic/kibana/issues/176882
describe.skip('embed mode', () => {
describe('embed mode', () => {
/*
* Note: The baseline images used in all of the screenshot tests in this test suite were taken directly from the CI environment
* in order to overcome a known issue with the pixel density of fonts being significantly different when running locally versus
Expand Down
Binary file modified test/functional/screenshots/baseline/dashboard_embed_mode.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 2f24c45

Please sign in to comment.