Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable filters for the alert search bar on the Observability Alerts page #178886

Merged

Conversation

maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Mar 18, 2024

Fixes #158400
Resolves #177431

Summary

This PR adds the filter option to the alert search bar.

Screen.Recording.2024-03-21.at.17.40.13.mov

🧪 How to test

  • Go to the Observability > Alerts page
  • Use filter and saved query functionalities, they should work as expected.
  • APM > Alerts tab should not show the filters, we can enable them separately if we want to.

Inspired by what @umbopepato implemented for the global alerts page!

@maryam-saeidi maryam-saeidi added the release_note:feature Makes this part of the condensed release notes label Mar 18, 2024
@maryam-saeidi
Copy link
Member Author

/ci

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@maryam-saeidi
Copy link
Member Author

/ci

@maryam-saeidi maryam-saeidi marked this pull request as ready for review March 21, 2024 16:52
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner March 21, 2024 16:52
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Mar 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using saved queries, if the query is manually removed by clicking the x on the query, it cannot be loaded again via saved queries until clear all is selected.

Screen.Recording.2024-03-26.at.11.30.17.AM.mov

@maryam-saeidi
Copy link
Member Author

@dominiqueclarke Nice catch! Fixed in 1ae5f57.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 261.5KB 262.7KB +1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke self-requested a review March 27, 2024 19:38
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maryam-saeidi maryam-saeidi merged commit 716b6f8 into elastic:main Mar 28, 2024
17 checks passed
@maryam-saeidi maryam-saeidi deleted the 177431-add-alert-search-bar-filters branch March 28, 2024 08:39
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Mar 28, 2024
@maryam-saeidi maryam-saeidi self-assigned this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:obs-ux-management Observability Management User Experience Team v8.14.0
Projects
None yet
6 participants