Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AO] Clearing search bar in alerts ui doesn't reflect in the url #158400

Closed
mohamedhamed-ahmed opened this issue May 24, 2023 · 2 comments · Fixed by #178886
Closed

[AO] Clearing search bar in alerts ui doesn't reflect in the url #158400

mohamedhamed-ahmed opened this issue May 24, 2023 · 2 comments · Fixed by #178886
Assignees
@maryam-saeidi
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.9.0

Comments

@mohamedhamed-ahmed
Copy link
Contributor

mohamedhamed-ahmed commented May 24, 2023 •
edited
Loading

📝 Summary:

Removing any applied search query from the unified search bar in the Alerts UI doesn't sync with the state in the URL and so doesn't reflect when navigating across tabs or refreshes.

Reproduce:

  1. Navigate to Observability > Alerts
  2. Types anything in the search bar ex: url.path > 5 and apply the search
  3. remove the search query
  4. refresh or navigate across tabs
  5. notice that the search query is still persisted in the URL
Screen.Recording.2023-05-24.at.17.45.45.mov
@mohamedhamed-ahmed mohamedhamed-ahmed added bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels May 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes v8.9.0 labels May 31, 2023
@kdelemme kdelemme self-assigned this May 31, 2023
@kdelemme kdelemme mentioned this issue May 31, 2023
Closed
@kdelemme kdelemme removed their assignment Jun 27, 2023
@maryam-saeidi maryam-saeidi added Team:obs-ux-management Observability Management User Experience Team and removed Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Mar 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@maryam-saeidi maryam-saeidi mentioned this issue Mar 18, 2024
Merged
maryam-saeidi added a commit that referenced this issue Mar 28, 2024
@maryam-saeidi
Enable filters for the alert search bar on the Observability Alerts p…
716b6f8 
…age (#178886)

Fixes #158400
Resolves #177431

## Summary

This PR adds the filter option to the alert search bar.


https://github.com/elastic/kibana/assets/12370520/d476dec4-e540-4379-b2cf-076fd27c13a0


### 🧪 How to test
- Go to the Observability > Alerts page
- Use filter and saved query functionalities, they should work as
expected.
- APM > Alerts tab should not show the filters, we can enable them
separately if we want to.

Inspired by what @umbopepato implemented for the global alerts page!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryam-saeidi maryam-saeidi

Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.9.0
Projects
None yet
Milestone
No milestone
5 participants
@kdelemme @mohamedhamed-ahmed @maryam-saeidi @elasticmachine @emma-raffenne