[Lens] show the "Requires field" validation message for empty visualization for inline editing #178393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… empty visualization for inline editing
mbondyra
added
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
|
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178237
In inline editing, the 'requires field' message appears even when the chart is empty. This behavior differs from the Lens editor, where the message is not shown when the chart is empty. The reason for this difference is that in Lens, we can easily start from an empty state and the chart workspace reflects it. However, in the inline Lens editor, we render the last correct state in the embeddable even if configuration is empty.
Adding this warning will help users understand why the state in the embeddable is desynchronized.