Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] show the standard Lens "Requires field" validation message for empty visualization #178237

Closed
mbondyra opened this issue Mar 7, 2024 · 2 comments · Fixed by #178393
Closed

[Lens] show the standard Lens "Requires field" validation message for empty visualization #178237

mbondyra opened this issue Mar 7, 2024 · 2 comments · Fixed by #178393
Assignees
@mbondyra
Labels
enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mbondyra
Copy link
Contributor

mbondyra commented Mar 7, 2024

At the moment, we only show missing dimension validation message if user already have some dimension filled.

Screenshot 2024-03-07 at 15 30 34 Screenshot 2024-03-07 at 15 30 42

We might want to change it for inline editing, because that would hint a user they are out of sync with what lens embeddable displays. 2 questions arises:

  1. Should we apply this change for both Lens editor and inline editor OR only for inline editor?
  2. If for Lens editor too, should we not apply it at the start of visualization? (when user just entered Lens and haven't start creating/removing dimensions) - that's a bit more complicated to achieve though

Originally posted by @mbondyra in #177790 (comment)
@mbondyra mbondyra mentioned this issue Mar 7, 2024
Merged
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 7, 2024
@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Mar 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 7, 2024
@stratoula
Copy link
Contributor

Yes this makes sense Marta, I like this proposal for inline editing 👍

@stratoula stratoula added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. enhancement New value added to drive a business result labels Mar 8, 2024
@mbondyra mbondyra self-assigned this Mar 8, 2024
@mbondyra mbondyra mentioned this issue Mar 11, 2024
Merged
mbondyra added a commit that referenced this issue Mar 12, 2024
@mbondyra @stratoula
[Lens] show the "Requires field" validation message for empty visuali…
d2d0c83 
…zation for inline editing (#178393)

Fixes #178237

In inline editing, the 'requires field' message appears even when the
chart is empty. This behavior differs from the Lens editor, where the
message is not shown when the chart is empty. The reason for this
difference is that in Lens, we can easily start from an empty state and
the chart workspace reflects it. However, in the inline Lens editor, we
render the last correct state in the embeddable even if configuration is
empty.

Adding this warning will help users understand why the state in the
embeddable is desynchronized.

Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbondyra mbondyra

Labels
enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
3 participants
@mbondyra @elasticmachine @stratoula