[Lens] [ES|QL] Fixes inline documentation in cloud #177774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
stratoula
changed the title
stratoula
added
release_note:skip
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
drewdaemon
approved these changes
Feb 25, 2024
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Feb 25, 2024
## Summary In the cloud distribution the documentation popovers are not rendered correctly (ES|QL and Lens) This is because the documentation.scss file is not loaded. This happens due to the sideEffects option. This is happening only on production mode and not on dev mode. You can use this a la carte instance for testing or create your own https://stratoula-pr-177774-fix-documentation-in-cloud.kbndev.co/ ### How to test Open the ES|QL inline documentation or the Lens formula inline documentation, (cherry picked from commit b4019a2)
stratoula
added a commit
that referenced
this pull request
Feb 25, 2024
…177775) # Backport This will backport the following commits from `main` to `8.13`: - [[Lens] [ES|QL] Fixes inline documentation in cloud (#177774)](#177774) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-25T12:32:45Z","message":"[Lens] [ES|QL] Fixes inline documentation in cloud (#177774)\n\n## Summary\r\n\r\nIn the cloud distribution the documentation popovers are not rendered\r\ncorrectly (ES|QL and Lens) This is because the documentation.scss file\r\nis not loaded. This happens due to the sideEffects option.\r\n\r\nThis is happening only on production mode and not on dev mode.\r\nYou can use this a la carte instance for testing or create your own\r\nhttps://stratoula-pr-177774-fix-documentation-in-cloud.kbndev.co/\r\n\r\n### How to test\r\nOpen the ES|QL inline documentation or the Lens formula inline\r\ndocumentation,","sha":"b4019a2e5c40131adf811530dddc8f6c6ac8d915","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","backport:prev-minor","Feature:ES|QL","v8.13.0","v8.14.0"],"number":177774,"url":"https://github.com/elastic/kibana/pull/177774","mergeCommit":{"message":"[Lens] [ES|QL] Fixes inline documentation in cloud (#177774)\n\n## Summary\r\n\r\nIn the cloud distribution the documentation popovers are not rendered\r\ncorrectly (ES|QL and Lens) This is because the documentation.scss file\r\nis not loaded. This happens due to the sideEffects option.\r\n\r\nThis is happening only on production mode and not on dev mode.\r\nYou can use this a la carte instance for testing or create your own\r\nhttps://stratoula-pr-177774-fix-documentation-in-cloud.kbndev.co/\r\n\r\n### How to test\r\nOpen the ES|QL inline documentation or the Lens formula inline\r\ndocumentation,","sha":"b4019a2e5c40131adf811530dddc8f6c6ac8d915"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177774","number":177774,"mergeCommit":{"message":"[Lens] [ES|QL] Fixes inline documentation in cloud (#177774)\n\n## Summary\r\n\r\nIn the cloud distribution the documentation popovers are not rendered\r\ncorrectly (ES|QL and Lens) This is because the documentation.scss file\r\nis not loaded. This happens due to the sideEffects option.\r\n\r\nThis is happening only on production mode and not on dev mode.\r\nYou can use this a la carte instance for testing or create your own\r\nhttps://stratoula-pr-177774-fix-documentation-in-cloud.kbndev.co/\r\n\r\n### How to test\r\nOpen the ES|QL inline documentation or the Lens formula inline\r\ndocumentation,","sha":"b4019a2e5c40131adf811530dddc8f6c6ac8d915"}}]}] BACKPORT-->
semd
pushed a commit
to semd/kibana
that referenced
this pull request
Mar 4, 2024
## Summary In the cloud distribution the documentation popovers are not rendered correctly (ES|QL and Lens) This is because the documentation.scss file is not loaded. This happens due to the sideEffects option. This is happening only on production mode and not on dev mode. You can use this a la carte instance for testing or create your own https://stratoula-pr-177774-fix-documentation-in-cloud.kbndev.co/ ### How to test Open the ES|QL inline documentation or the Lens formula inline documentation,
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
## Summary In the cloud distribution the documentation popovers are not rendered correctly (ES|QL and Lens) This is because the documentation.scss file is not loaded. This happens due to the sideEffects option. This is happening only on production mode and not on dev mode. You can use this a la carte instance for testing or create your own https://stratoula-pr-177774-fix-documentation-in-cloud.kbndev.co/ ### How to test Open the ES|QL inline documentation or the Lens formula inline documentation,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the cloud distribution the documentation popovers are not rendered correctly (ES|QL and Lens) This is because the documentation.scss file is not loaded. This happens due to the sideEffects option.
This is happening only on production mode and not on dev mode.
You can use this a la carte instance for testing or create your own https://stratoula-pr-177774-fix-documentation-in-cloud.kbndev.co/
How to test
Open the ES|QL inline documentation or the Lens formula inline documentation,