Skip to content

Commit

Permalink
[maps] update ES|QL copy to align with controls copy (#177668)
Browse files Browse the repository at this point in the history
@teresaalvarezsoler suggested updating ES|QL copy to align with existing
controls copy

Controls copy

![image](https://github.com/elastic/kibana/assets/373691/976d24a6-6274-44a5-9974-69a533e88983)

Updated ES|QL copy
<img width="300" alt="Screenshot 2024-02-22 at 4 06 56 PM"
src="https://github.com/elastic/kibana/assets/373691/86604d42-771b-439c-ba61-2d5e9bcc7a4a">
  • Loading branch information
nreese authored Feb 24, 2024
1 parent 037d087 commit eb8df74
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ export function CreateSourceEditor(props: Props) {
<EuiFormRow>
<EuiSwitch
label={i18n.translate('xpack.maps.esqlSource.narrowByGlobalSearchLabel', {
defaultMessage: `Narrow ES|QL statement by global search`,
defaultMessage: `Apply global search to ES|QL statement`,
})}
checked={narrowByGlobalSearch}
onChange={(event: EuiSwitchEvent) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function NarrowByMapBounds(props: Omit<NarrowByFieldProps, 'switchLabel'
return (
<NarrowByField
switchLabel={i18n.translate('xpack.maps.esqlSource.narrowByMapExtentLabel', {
defaultMessage: 'Narrow ES|QL statement by visible map area',
defaultMessage: 'Dynamically filter for data in the visible map area',
})}
fieldTypes={[ES_GEO_FIELD_TYPE.GEO_POINT, ES_GEO_FIELD_TYPE.GEO_SHAPE]}
{...props}
Expand All @@ -27,7 +27,7 @@ export function NarrowByTime(props: Omit<NarrowByFieldProps, 'switchLabel' | 'fi
return (
<NarrowByField
switchLabel={i18n.translate('xpack.maps.esqlSource.narrowByGlobalTimeLabel', {
defaultMessage: `Narrow ES|QL statement by global time`,
defaultMessage: `Apply global time range to ES|QL statement`,
})}
fieldTypes={['date']}
{...props}
Expand Down Expand Up @@ -96,7 +96,7 @@ function NarrowByField(props: NarrowByFieldProps) {
{props.narrowByField && (
<EuiFormRow
label={i18n.translate('xpack.maps.source.esql.narrowByFieldLabel', {
defaultMessage: 'Narrow by',
defaultMessage: 'Filter by',
})}
display="columnCompressed"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jest.mock('../../../kibana_services', () => {
describe('UpdateSourceEditor', () => {
describe('narrow by map bounds switch', () => {
function getNarrowByMapBoundsSwitch() {
return screen.getByText('Narrow ES|QL statement by visible map area');
return screen.getByText('Dynamically filter for data in the visible map area');
}

test('should set geoField when checked and geo field is not set', async () => {
Expand Down Expand Up @@ -97,7 +97,7 @@ describe('UpdateSourceEditor', () => {

describe('narrow by time switch', () => {
function getNarrowByTimeSwitch() {
return screen.getByText('Narrow ES|QL statement by global time');
return screen.getByText('Apply global time range to ES|QL statement');
}

test('should set dateField when checked and date field is not set', async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export function UpdateSourceEditor(props: Props) {
<EuiFormRow>
<EuiSwitch
label={i18n.translate('xpack.maps.esqlSource.narrowByGlobalSearchLabel', {
defaultMessage: `Narrow ES|QL statement by global search`,
defaultMessage: `Apply global search to ES|QL statement`,
})}
checked={props.sourceDescriptor.narrowByGlobalSearch}
onChange={(event: EuiSwitchEvent) => {
Expand Down

0 comments on commit eb8df74

Please sign in to comment.