Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom threshold][Alert details page] Deprecate feature flag for Custom threshold rule alert details page #176666

Merged

Conversation

maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Feb 12, 2024

Closes #153867

Summary

This PR deprecates the following feature flag for the Custom threshold rule alert details page.

xpack.observability.unsafe.alertDetails.observability.enabled

image

🧪 How to test

  • Remove xpack.observability.unsafe.alertDetails.observability.enabled from Kibana config
  • Create a custom threshold rule
  • Check the alert details page
    • From alert table's flyout
    • From action variables
  • Add xpack.observability.unsafe.alertDetails.observability.enabled to the Kibana config
  • You should see the following warning
    [WARN ][config.deprecation] You no longer need to configure "xpack.observability.unsafe.alertDetails.observability.enabled".
    

Release note

Adds a dedicated alert details page for the Custom threshold rule. When a threshold is breached, the alert details page helps users quickly triage the alert, showing details and context around that alert such as when the alert started, its current status, and other details. When a log rate-based threshold is breached, the alert details page also includes an automatic log rate analysis depicting shared characteristics among log messages contributing to this change and in-context Observability AI Assistant to provide further insight and remedy suggestions.

@maryam-saeidi maryam-saeidi added release_note:feature Makes this part of the condensed release notes Feature:Alert Details Page Observability ux management team Feature: Custom threshold Observability custom threshold rule type labels Feb 12, 2024
@maryam-saeidi maryam-saeidi self-assigned this Feb 12, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@maryam-saeidi maryam-saeidi marked this pull request as ready for review February 12, 2024 10:07
@maryam-saeidi maryam-saeidi requested review from a team as code owners February 12, 2024 10:07
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Feb 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryam-saeidi maryam-saeidi enabled auto-merge (squash) February 13, 2024 16:19
@maryam-saeidi maryam-saeidi enabled auto-merge (squash) February 13, 2024 22:55
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/rule-data-utils 117 119 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 642.6KB 642.9KB +341.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 103.0KB 103.4KB +429.0B
Unknown metric groups

API count

id before after diff
@kbn/rule-data-utils 120 122 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi merged commit 7666a41 into elastic:main Feb 14, 2024
19 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Feb 14, 2024
@maryam-saeidi maryam-saeidi deleted the 153867-deprecate-feature-flag branch February 14, 2024 06:21
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
…tom threshold rule alert details page (elastic#176666)

Closes elastic#153867

## Summary

This PR deprecates the following feature flag for the Custom threshold
rule alert details page.
```
xpack.observability.unsafe.alertDetails.observability.enabled
```


![image](https://github.com/elastic/kibana/assets/12370520/b0b7bfa4-5f53-48bc-a44c-2f999a3c53f6)


## 🧪 How to test
- Remove `xpack.observability.unsafe.alertDetails.observability.enabled`
from Kibana config
- Create a custom threshold rule
- Check the alert details page
    - From alert table's flyout
    - From action variables
- Add `xpack.observability.unsafe.alertDetails.observability.enabled` to
the Kibana config
- You should see the following warning
  ```
[WARN ][config.deprecation] You no longer need to configure
"xpack.observability.unsafe.alertDetails.observability.enabled".
  ```

## Release note

- Adds a dedicated alert details page for the Custom threshold rule.
When a threshold is breached, the alert details page helps users quickly
triage the alert, showing details and context around that alert such as
when the alert started, its current status, and other details. When a
log rate-based threshold is breached, the alert details page also
includes an automatic log rate analysis depicting shared characteristics
among log messages contributing to this change and in-context
Observability AI Assistant to provide further insight and remedy
suggestions.
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
…tom threshold rule alert details page (elastic#176666)

Closes elastic#153867

## Summary

This PR deprecates the following feature flag for the Custom threshold
rule alert details page.
```
xpack.observability.unsafe.alertDetails.observability.enabled
```


![image](https://github.com/elastic/kibana/assets/12370520/b0b7bfa4-5f53-48bc-a44c-2f999a3c53f6)


## 🧪 How to test
- Remove `xpack.observability.unsafe.alertDetails.observability.enabled`
from Kibana config
- Create a custom threshold rule
- Check the alert details page
    - From alert table's flyout
    - From action variables
- Add `xpack.observability.unsafe.alertDetails.observability.enabled` to
the Kibana config
- You should see the following warning
  ```
[WARN ][config.deprecation] You no longer need to configure
"xpack.observability.unsafe.alertDetails.observability.enabled".
  ```

## Release note

- Adds a dedicated alert details page for the Custom threshold rule.
When a threshold is breached, the alert details page helps users quickly
triage the alert, showing details and context around that alert such as
when the alert started, its current status, and other details. When a
log rate-based threshold is breached, the alert details page also
includes an automatic log rate analysis depicting shared characteristics
among log messages contributing to this change and in-context
Observability AI Assistant to provide further insight and remedy
suggestions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Alert Details Page Observability ux management team Feature: Custom threshold Observability custom threshold rule type release_note:feature Makes this part of the condensed release notes Team:obs-ux-management Observability Management User Experience Team v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Alert details page] Deprecate Threshold Rule feature flag for alert details page
8 participants