Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alert details page] Deprecate Threshold Rule feature flag for alert details page #153867

Closed
Tracked by #145117
maryam-saeidi opened this issue Mar 28, 2023 · 3 comments · Fixed by #176666
Closed
Tracked by #145117

[Alert details page] Deprecate Threshold Rule feature flag for alert details page #153867

maryam-saeidi opened this issue Mar 28, 2023 · 3 comments · Fixed by #176666
Assignees
@maryam-saeidi
Labels
Feature:Alert Details Page Observability ux management team Team:obs-ux-management Observability Management User Experience Team v8.8.0
Milestone
8.11

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Mar 28, 2023 •
edited by emma-raffenne
Loading

📝 Summary

After completing work on the alert details page for threshold rule, we need to remove the related feature flag.

Also, we need to update alertDetailsUrl to the new alert details page: (example)

getAlertDetailsUrl(libs.basePath, spaceId, alertUuid)

✅ Acceptance Criteria

  • Remove metric threshold related feature flag for alert details page
  • Update alertDetailsUrl in action variables to point to the new pages
@maryam-saeidi maryam-saeidi mentioned this issue Mar 28, 2023
Closed
41 tasks
@maryam-saeidi maryam-saeidi added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0 labels Mar 28, 2023
@maryam-saeidi maryam-saeidi self-assigned this Mar 28, 2023
@maryam-saeidi maryam-saeidi added the Feature:Alert Details Page Observability ux management team label Mar 28, 2023
@maryam-saeidi maryam-saeidi changed the title [AO] Remove feature flag [AO] Remove metric threshold feature flag Mar 28, 2023
@emma-raffenne emma-raffenne changed the title [AO] Remove metric threshold feature flag [AO] Remove Threshold Rule feature flag Jul 19, 2023
@emma-raffenne emma-raffenne added this to the 8.11 milestone Jul 20, 2023
@maryam-saeidi maryam-saeidi removed their assignment Aug 7, 2023
@maryam-saeidi maryam-saeidi changed the title [AO] Remove Threshold Rule feature flag [AO] Remove Threshold Rule feature flag for alert details page Aug 7, 2023
@paulb-elastic
Copy link
Contributor

To be planned as part of https://github.com/elastic/actionable-observability/issues/47

@paulb-elastic paulb-elastic removed the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Nov 3, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 3, 2023
@paulb-elastic paulb-elastic added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Nov 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 3, 2023
@paulb-elastic paulb-elastic removed the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Nov 3, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 3, 2023
@jsanz jsanz added the Team:obs-ux-management Observability Management User Experience Team label Nov 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 20, 2023
@maryam-saeidi maryam-saeidi changed the title [AO] Remove Threshold Rule feature flag for alert details page [Alert details view] Remove Threshold Rule feature flag for alert details page Dec 21, 2023
@maryam-saeidi maryam-saeidi changed the title [Alert details view] Remove Threshold Rule feature flag for alert details page [Alert details page] Remove Threshold Rule feature flag for alert details page Dec 21, 2023
@maryam-saeidi maryam-saeidi self-assigned this Feb 12, 2024
@maryam-saeidi maryam-saeidi changed the title [Alert details page] Remove Threshold Rule feature flag for alert details page [Alert details page] Deprecate Threshold Rule feature flag for alert details page Feb 12, 2024
@maryam-saeidi maryam-saeidi mentioned this issue Feb 12, 2024
Merged
maryam-saeidi added a commit that referenced this issue Feb 14, 2024
@maryam-saeidi
[Custom threshold][Alert details page] Deprecate feature flag for Cus…
7666a41 
…tom threshold rule alert details page (#176666)

Closes #153867

## Summary

This PR deprecates the following feature flag for the Custom threshold
rule alert details page.
```
xpack.observability.unsafe.alertDetails.observability.enabled
```


![image](https://github.com/elastic/kibana/assets/12370520/b0b7bfa4-5f53-48bc-a44c-2f999a3c53f6)


## 🧪 How to test
- Remove `xpack.observability.unsafe.alertDetails.observability.enabled`
from Kibana config
- Create a custom threshold rule
- Check the alert details page
    - From alert table's flyout
    - From action variables
- Add `xpack.observability.unsafe.alertDetails.observability.enabled` to
the Kibana config
- You should see the following warning
  ```
[WARN ][config.deprecation] You no longer need to configure
"xpack.observability.unsafe.alertDetails.observability.enabled".
  ```

## Release note

- Adds a dedicated alert details page for the Custom threshold rule.
When a threshold is breached, the alert details page helps users quickly
triage the alert, showing details and context around that alert such as
when the alert started, its current status, and other details. When a
log rate-based threshold is breached, the alert details page also
includes an automatic log rate analysis depicting shared characteristics
among log messages contributing to this change and in-context
Observability AI Assistant to provide further insight and remedy
suggestions.
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@maryam-saeidi @CoenWarmer
[Custom threshold][Alert details page] Deprecate feature flag for Cus…
ee30caa 
…tom threshold rule alert details page (elastic#176666)

Closes elastic#153867

## Summary

This PR deprecates the following feature flag for the Custom threshold
rule alert details page.
```
xpack.observability.unsafe.alertDetails.observability.enabled
```


![image](https://github.com/elastic/kibana/assets/12370520/b0b7bfa4-5f53-48bc-a44c-2f999a3c53f6)


## 🧪 How to test
- Remove `xpack.observability.unsafe.alertDetails.observability.enabled`
from Kibana config
- Create a custom threshold rule
- Check the alert details page
    - From alert table's flyout
    - From action variables
- Add `xpack.observability.unsafe.alertDetails.observability.enabled` to
the Kibana config
- You should see the following warning
  ```
[WARN ][config.deprecation] You no longer need to configure
"xpack.observability.unsafe.alertDetails.observability.enabled".
  ```

## Release note

- Adds a dedicated alert details page for the Custom threshold rule.
When a threshold is breached, the alert details page helps users quickly
triage the alert, showing details and context around that alert such as
when the alert started, its current status, and other details. When a
log rate-based threshold is breached, the alert details page also
includes an automatic log rate analysis depicting shared characteristics
among log messages contributing to this change and in-context
Observability AI Assistant to provide further insight and remedy
suggestions.
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@maryam-saeidi @fkanout
[Custom threshold][Alert details page] Deprecate feature flag for Cus…
5aeedf0 
…tom threshold rule alert details page (elastic#176666)

Closes elastic#153867

## Summary

This PR deprecates the following feature flag for the Custom threshold
rule alert details page.
```
xpack.observability.unsafe.alertDetails.observability.enabled
```


![image](https://github.com/elastic/kibana/assets/12370520/b0b7bfa4-5f53-48bc-a44c-2f999a3c53f6)


## 🧪 How to test
- Remove `xpack.observability.unsafe.alertDetails.observability.enabled`
from Kibana config
- Create a custom threshold rule
- Check the alert details page
    - From alert table's flyout
    - From action variables
- Add `xpack.observability.unsafe.alertDetails.observability.enabled` to
the Kibana config
- You should see the following warning
  ```
[WARN ][config.deprecation] You no longer need to configure
"xpack.observability.unsafe.alertDetails.observability.enabled".
  ```

## Release note

- Adds a dedicated alert details page for the Custom threshold rule.
When a threshold is breached, the alert details page helps users quickly
triage the alert, showing details and context around that alert such as
when the alert started, its current status, and other details. When a
log rate-based threshold is breached, the alert details page also
includes an automatic log rate analysis depicting shared characteristics
among log messages contributing to this change and in-context
Observability AI Assistant to provide further insight and remedy
suggestions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryam-saeidi maryam-saeidi

Labels
Feature:Alert Details Page Observability ux management team Team:obs-ux-management Observability Management User Experience Team v8.8.0
Projects
None yet
Milestone
8.11
5 participants
@jsanz @maryam-saeidi @elasticmachine @paulb-elastic @emma-raffenne