-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.12][Fleet] fix API not allowing to upgrade to a newer version when version differs only in patch #175765
Merged
juliaElastic
merged 4 commits into
elastic:8.12
from
juliaElastic:backport/8.12/pr-175198
Jan 29, 2024
Merged
[8.12][Fleet] fix API not allowing to upgrade to a newer version when version differs only in patch #175765
juliaElastic
merged 4 commits into
elastic:8.12
from
juliaElastic:backport/8.12/pr-175198
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes elastic#175186 Fixed UI error in the custom upgrade version input. To verify: - enroll an agent with version 8.13-snapshot - click upgrade agent - type anything and then clear the input - the UI should not move to error state Fixed another bug when I tested to upgrade to a newer build version (newer patch), and got an API error saying can't upgrade to a newer version than kibana version. To verify: - click upgrade agent, type `8.13.1+build123456789`, submit - verify that the API returns 200 https://github.com/elastic/kibana/assets/90178898/80b4e12e-3aad-41b7-b39d-8d28d6253772 - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/ci |
juliaElastic
added a commit
that referenced
this pull request
Jan 29, 2024
…175775) ## Summary Adding the fix in #175765 to main too. To verify: - add a fleet-server version 8.12.0 - enroll an agent version 8.12.0-SNAPSHOT - take the agent id and in console run this API request ``` POST kbn:/api/fleet/agents/6a56f865-a611-4921-9f24-87757259223e/upgrade { "version": "8.12.1-SNAPSHOT" } ``` - verify that the API returns 200 Relates #168502
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
jlind23
approved these changes
Jan 29, 2024
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…lastic#175775) ## Summary Adding the fix in elastic#175765 to main too. To verify: - add a fleet-server version 8.12.0 - enroll an agent version 8.12.0-SNAPSHOT - take the agent id and in console run this API request ``` POST kbn:/api/fleet/agents/6a56f865-a611-4921-9f24-87757259223e/upgrade { "version": "8.12.1-SNAPSHOT" } ``` - verify that the API returns 200 Relates elastic#168502
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…lastic#175775) ## Summary Adding the fix in elastic#175765 to main too. To verify: - add a fleet-server version 8.12.0 - enroll an agent version 8.12.0-SNAPSHOT - take the agent id and in console run this API request ``` POST kbn:/api/fleet/agents/6a56f865-a611-4921-9f24-87757259223e/upgrade { "version": "8.12.1-SNAPSHOT" } ``` - verify that the API returns 200 Relates elastic#168502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175766
[8.12][Fleet] Partial backport of #175198
To verify:
Relates #168502