[Fleet] fix error when clearing upgrade input #175198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kpollich
approved these changes
Jan 22, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
juliaElastic
added a commit
to juliaElastic/kibana
that referenced
this pull request
Jan 29, 2024
Closes elastic#175186 Fixed UI error in the custom upgrade version input. To verify: - enroll an agent with version 8.13-snapshot - click upgrade agent - type anything and then clear the input - the UI should not move to error state Fixed another bug when I tested to upgrade to a newer build version (newer patch), and got an API error saying can't upgrade to a newer version than kibana version. To verify: - click upgrade agent, type `8.13.1+build123456789`, submit - verify that the API returns 200 https://github.com/elastic/kibana/assets/90178898/80b4e12e-3aad-41b7-b39d-8d28d6253772 - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
juliaElastic
added a commit
that referenced
this pull request
Jan 29, 2024
… version differs only in patch (#175765) Fixes #175766 [8.12][Fleet] Partial backport of #175198 To verify: - add a fleet-server version 8.12.0 - enroll an agent version 8.12.0-SNAPSHOT - take the agent id and in console run this API request ``` POST kbn:/api/fleet/agents/6a56f865-a611-4921-9f24-87757259223e/upgrade { "version": "8.12.1-SNAPSHOT" } ``` - verify that the API returns 200 Relates #168502
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary Closes elastic#175186 Fixed UI error in the custom upgrade version input. To verify: - enroll an agent with version 8.13-snapshot - click upgrade agent - type anything and then clear the input - the UI should not move to error state Fixed another bug when I tested to upgrade to a newer build version (newer patch), and got an API error saying can't upgrade to a newer version than kibana version. To verify: - click upgrade agent, type `8.13.1+build123456789`, submit - verify that the API returns 200 https://github.com/elastic/kibana/assets/90178898/80b4e12e-3aad-41b7-b39d-8d28d6253772 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #175186
Fixed UI error in the custom upgrade version input.
To verify:
Fixed another bug when I tested to upgrade to a newer build version (newer patch), and got an API error saying can't upgrade to a newer version than kibana version.
To verify:
8.13.1+build123456789, submitupgrade_modal_fix.mov
Checklist