[Lens] turn on veil in the right place #175550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
approved these changes
Jan 25, 2024
|
/ci |
2 similar comments
|
/ci |
|
/ci |
|
Closing in favor of #175691 Drew |
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
stratoula
added a commit
that referenced
this pull request
Jan 26, 2024
## Summary Follow up of #171081 - Address Julia's last comment on the PR - Fix the veil bug correctly as Drew proposed here #175550 instead of adding a variable in the embeddable level as I did in the aforementioned PR. We dont want the veil in the embeddable level --------- Co-authored-by: Julia Rechkunova <[email protected]>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary Follow up of elastic#171081 - Address Julia's last comment on the PR - Fix the veil bug correctly as Drew proposed here elastic#175550 instead of adding a variable in the embeddable level as I did in the aforementioned PR. We dont want the veil in the embeddable level --------- Co-authored-by: Julia Rechkunova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where the veil was enabled on embeddable instead of in the editor.