[Lens] Value based ESQL followup (elastic#175691)

## Summary Follow up of elastic#171081 - Address Julia's last comment on the PR - Fix the veil bug correctly as Drew proposed here elastic#175550 instead of adding a variable in the embeddable level as I did in the aforementioned PR. We dont want the veil in the embeddable level --------- Co-authored-by: Julia Rechkunova <[email protected]>
CoenWarmer · Feb 15, 2024 · 17c5202 · 17c5202
1 parent c4a45b4
commit 17c5202
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/src/plugins/discover/public/application/main/components/layout/discover_histogram_layout.tsx b/src/plugins/discover/public/application/main/components/layout/discover_histogram_layout.tsx
@@ -14,6 +14,7 @@ import { Datatable } from '@kbn/expressions-plugin/common';
 import { useDiscoverHistogram } from './use_discover_histogram';
 import { type DiscoverMainContentProps, DiscoverMainContent } from './discover_main_content';
 import { useAppStateSelector } from '../../services/discover_app_state_container';
+import { FetchStatus } from '../../../types';
 
 export interface DiscoverHistogramLayoutProps extends DiscoverMainContentProps {
   container: HTMLElement | null;
@@ -54,8 +55,7 @@ export const DiscoverHistogramLayout = ({
     if (
       isPlainRecord &&
       datatable &&
-      datatable &&
-      ['partial', 'complete'].includes(datatable.fetchStatus)
+      [FetchStatus.PARTIAL, FetchStatus.COMPLETE].includes(datatable.fetchStatus)
     ) {
       return {
         type: 'datatable' as 'datatable',

diff --git a/src/plugins/unified_histogram/public/chart/histogram.tsx b/src/plugins/unified_histogram/public/chart/histogram.tsx
@@ -225,7 +225,6 @@ export function Histogram({
           {...lensProps}
           disableTriggers={disableTriggers}
           disabledActions={disabledActions}
-          shouldUseSizeTransitionVeil={false}
           onFilter={onFilter}
           onBrushEnd={onBrushEnd}
           withDefaultActions={withDefaultActions}

diff --git a/...plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx b/...plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx
@@ -781,6 +781,7 @@ export const VisualizationWrapper = ({
         onRender$={onRenderHandler}
         inspectorAdapters={lensInspector.adapters}
         executionContext={executionContext}
+        shouldUseSizeTransitionVeil={true}
         renderMode="edit"
         renderError={(errorMessage?: string | null, error?: ExpressionRenderError | null) => {
           const errorsFromRequest = getOriginalRequestErrorMessages(error || null);

diff --git a/x-pack/plugins/lens/public/embeddable/embeddable.tsx b/x-pack/plugins/lens/public/embeddable/embeddable.tsx
@@ -172,7 +172,6 @@ interface LensBaseEmbeddableInput extends EmbeddableInput {
   style?: React.CSSProperties;
   className?: string;
   noPadding?: boolean;
-  shouldUseSizeTransitionVeil?: boolean;
   onBrushEnd?: (data: Simplify<BrushTriggerEvent['data'] & PreventableEvent>) => void;
   onLoad?: (
     isLoading: boolean,
@@ -1153,7 +1152,6 @@ export class Embeddable
                 this.logError('runtime');
               }}
               noPadding={this.visDisplayOptions.noPadding}
-              shouldUseSizeTransitionVeil={this.input.shouldUseSizeTransitionVeil}
             />
           </KibanaThemeProvider>
           <MessagesBadge