Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.12] [ResponseOps][Connectors] Fix bug in PagerDuty Connector (#175507) #175540

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

)

Fixes elastic#175342

## Summary

The Pagerduty action UI does not allow users to save when there are
linting errors in the `Custom Details` field.

Previously the validation was skipped if there were Mustache templates
in the field.

(cherry picked from commit 8fe7433)
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / When the add exception modal is opened exception list type is NOT "endpoint" ("rule_default" or "detection") bulk closeable alert data is passed in should have the bulk close checkbox enabled
  • [job] [logs] Jest Tests #1 / When the add exception modal is opened exception list type is NOT "endpoint" ("rule_default" or "detection") bulk closeable alert data is passed in when a "is in list" entry is added should have the bulk close checkbox disabled

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 536.5KB 536.5KB -8.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
stackConnectors 43.1KB 43.1KB +31.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @adcoelho

@kibanamachine kibanamachine merged commit b281d4c into elastic:8.12 Jan 25, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants