[8.12] [Fleet] Fix incorrect count of agents in bulk actions (#175318) (

#175527)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Fleet] Fix incorrect count of agents in bulk actions
(#175318)](#175318)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cristina
Amico","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-25T11:29:25Z","message":"[Fleet]
Fix incorrect count of agents in bulk actions (#175318)\n\nFixes
https://github.com/elastic/kibana/issues/171914\r\n\r\n## Summary\r\nFix
a small issue occurring when there are inactive agents, both
regular\r\nand managed.\r\n\r\nAnother PR with some refactoring for this
component will follow.\r\n\r\n### Repro steps\r\n\r\n- Enroll fleet
server on fleet-server-policy - make sure to have two\r\ninactive fleet
server agents on this policy as well\r\n- Enroll ~20 agents with horde
and make them inactive\r\n- Make fleet server policy \"managed\"\r\n-
Select \"inactive\" in the status filter\r\n- Click on \"Select agents
on all pages\"\r\n- The bulk actions shouldn't report negative actions.
If the count is 0,\r\nthe actions will appear disabled\r\n\r\n####
Before\r\n![Screenshot 2024-01-22 at 15
59\r\n42](https://github.com/elastic/kibana/assets/16084106/cb8c6c80-b23f-4415-af2a-b4de8ae387f6)\r\n\r\n####
After\r\n![Screenshot 2024-01-24 at 15
53\r\n53](https://github.com/elastic/kibana/assets/16084106/6b020016-6171-43d7-bc12-685bf01b7989)\r\n\r\n\r\n###
Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"f2fb3ee768f62aca11a6b3adae0514e1b1f56fcd","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","backport:prev-minor","v8.13.0"],"title":"[Fleet]
Fix incorrect count of agents in bulk
actions","number":175318,"url":"https://github.com/elastic/kibana/pull/175318","mergeCommit":{"message":"[Fleet]
Fix incorrect count of agents in bulk actions (#175318)\n\nFixes
https://github.com/elastic/kibana/issues/171914\r\n\r\n## Summary\r\nFix
a small issue occurring when there are inactive agents, both
regular\r\nand managed.\r\n\r\nAnother PR with some refactoring for this
component will follow.\r\n\r\n### Repro steps\r\n\r\n- Enroll fleet
server on fleet-server-policy - make sure to have two\r\ninactive fleet
server agents on this policy as well\r\n- Enroll ~20 agents with horde
and make them inactive\r\n- Make fleet server policy \"managed\"\r\n-
Select \"inactive\" in the status filter\r\n- Click on \"Select agents
on all pages\"\r\n- The bulk actions shouldn't report negative actions.
If the count is 0,\r\nthe actions will appear disabled\r\n\r\n####
Before\r\n![Screenshot 2024-01-22 at 15
59\r\n42](https://github.com/elastic/kibana/assets/16084106/cb8c6c80-b23f-4415-af2a-b4de8ae387f6)\r\n\r\n####
After\r\n![Screenshot 2024-01-24 at 15
53\r\n53](https://github.com/elastic/kibana/assets/16084106/6b020016-6171-43d7-bc12-685bf01b7989)\r\n\r\n\r\n###
Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"f2fb3ee768f62aca11a6b3adae0514e1b1f56fcd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175318","number":175318,"mergeCommit":{"message":"[Fleet]
Fix incorrect count of agents in bulk actions (#175318)\n\nFixes
https://github.com/elastic/kibana/issues/171914\r\n\r\n## Summary\r\nFix
a small issue occurring when there are inactive agents, both
regular\r\nand managed.\r\n\r\nAnother PR with some refactoring for this
component will follow.\r\n\r\n### Repro steps\r\n\r\n- Enroll fleet
server on fleet-server-policy - make sure to have two\r\ninactive fleet
server agents on this policy as well\r\n- Enroll ~20 agents with horde
and make them inactive\r\n- Make fleet server policy \"managed\"\r\n-
Select \"inactive\" in the status filter\r\n- Click on \"Select agents
on all pages\"\r\n- The bulk actions shouldn't report negative actions.
If the count is 0,\r\nthe actions will appear disabled\r\n\r\n####
Before\r\n![Screenshot 2024-01-22 at 15
59\r\n42](https://github.com/elastic/kibana/assets/16084106/cb8c6c80-b23f-4415-af2a-b4de8ae387f6)\r\n\r\n####
After\r\n![Screenshot 2024-01-24 at 15
53\r\n53](https://github.com/elastic/kibana/assets/16084106/6b020016-6171-43d7-bc12-685bf01b7989)\r\n\r\n\r\n###
Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"f2fb3ee768f62aca11a6b3adae0514e1b1f56fcd"}}]}]
BACKPORT-->

Co-authored-by: Cristina Amico <[email protected]>

x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/bulk_actions.test.tsx

@@ -30,6 +30,7 @@ const defaultProps = {
   shownAgents: 10,
   inactiveShownAgents: 0,
   totalManagedAgentIds: [],
+  inactiveManagedAgentIds: [],
   selectionMode: 'manual',
   currentQuery: '',
   selectedAgents: [],
@@ -126,6 +127,10 @@ describe('AgentBulkActions', () => {
   });
 
   describe('When in query mode', () => {
+    mockedExperimentalFeaturesService.get.mockReturnValue({
+      diagnosticFileUploadEnabled: true,
+    } as any);
+
     it('should show correct actions for active agents when no managed policies exist', async () => {
       const results = render({
         ...defaultProps,
@@ -162,15 +167,57 @@ describe('AgentBulkActions', () => {
 
       expect(results.getByText('Add / remove tags').closest('button')!).toBeEnabled();
       expect(results.getByText('Assign to new policy').closest('button')!).toBeEnabled();
-      expect(results.getByText('Unenroll 8 agents').closest('button')!).toBeEnabled();
-      expect(results.getByText('Upgrade 8 agents').closest('button')!).toBeEnabled();
-      expect(results.getByText('Schedule upgrade for 8 agents').closest('button')!).toBeDisabled();
       expect(
         results.getByText('Request diagnostics for 8 agents').closest('button')!
       ).toBeEnabled();
+      expect(results.getByText('Unenroll 8 agents').closest('button')!).toBeEnabled();
+      expect(results.getByText('Upgrade 8 agents').closest('button')!).toBeEnabled();
+      expect(results.getByText('Schedule upgrade for 8 agents').closest('button')!).toBeDisabled();
       expect(results.getByText('Restart upgrade 8 agents').closest('button')!).toBeEnabled();
     });
 
+    it('should show correct actions also when there are inactive managed agents', async () => {
+      const results = render({
+        ...defaultProps,
+        inactiveManagedAgentIds: ['agentId1', 'agentId2'],
+        totalManagedAgentIds: ['agentId1', 'agentId2', 'agentId3'],
+        selectionMode: 'query',
+      });
+
+      const bulkActionsButton = results.getByTestId('agentBulkActionsButton');
+      await act(async () => {
+        fireEvent.click(bulkActionsButton);
+      });
+
+      expect(results.getByText('Add / remove tags').closest('button')!).toBeEnabled();
+      expect(results.getByText('Assign to new policy').closest('button')!).toBeEnabled();
+      expect(results.getByText('Unenroll 9 agents').closest('button')!).toBeEnabled();
+      expect(results.getByText('Upgrade 9 agents').closest('button')!).toBeEnabled();
+      expect(results.getByText('Schedule upgrade for 9 agents').closest('button')!).toBeDisabled();
+      expect(results.getByText('Restart upgrade 9 agents').closest('button')!).toBeEnabled();
+    });
+
+    it('should show disabled actions when only inactive agents are selected', async () => {
+      const results = render({
+        ...defaultProps,
+        inactiveShownAgents: 10,
+        selectedAgents: [{ id: 'agent1' }, { id: 'agent2' }] as Agent[],
+        selectionMode: 'query',
+      });
+
+      const bulkActionsButton = results.getByTestId('agentBulkActionsButton');
+      await act(async () => {
+        fireEvent.click(bulkActionsButton);
+      });
+
+      expect(results.getByText('Add / remove tags').closest('button')!).toBeDisabled();
+      expect(results.getByText('Assign to new policy').closest('button')!).toBeDisabled();
+      expect(results.getByText('Unenroll 0 agents').closest('button')!).toBeDisabled();
+      expect(results.getByText('Upgrade 0 agents').closest('button')!).toBeDisabled();
+      expect(results.getByText('Schedule upgrade for 0 agents').closest('button')!).toBeDisabled();
+      expect(results.getByText('Restart upgrade 0 agents').closest('button')!).toBeDisabled();
+    });
+
     it('should generate a correct kuery to select agents', async () => {
       const results = render({
         ...defaultProps,

x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/bulk_actions.tsx

@@ -38,6 +38,7 @@ export interface Props {
   shownAgents: number;
   inactiveShownAgents: number;
   totalManagedAgentIds: string[];
+  inactiveManagedAgentIds: string[];
   selectionMode: SelectionMode;
   currentQuery: string;
   selectedAgents: Agent[];
@@ -51,6 +52,7 @@ export const AgentBulkActions: React.FunctionComponent<Props> = ({
   shownAgents,
   inactiveShownAgents,
   totalManagedAgentIds,
+  inactiveManagedAgentIds,
   selectionMode,
   currentQuery,
   selectedAgents,
@@ -91,18 +93,19 @@ export const AgentBulkActions: React.FunctionComponent<Props> = ({
     }
   }, [currentQuery, totalManagedAgentIds]);
 
-  // Check if user is working with only inactive agents
-  const atLeastOneActiveAgentSelected =
-    selectionMode === 'manual'
-      ? !!selectedAgents.find((agent) => agent.active)
-      : shownAgents > inactiveShownAgents;
   const totalActiveAgents = shownAgents - inactiveShownAgents;
 
+  // exclude inactive agents from the count
   const agentCount =
     selectionMode === 'manual'
       ? selectedAgents.length
-      : totalActiveAgents - totalManagedAgentIds?.length;
+      : totalActiveAgents - (totalManagedAgentIds?.length - inactiveManagedAgentIds?.length);
 
+  // Check if user is working with only inactive agents
+  const atLeastOneActiveAgentSelected =
+    selectionMode === 'manual'
+      ? !!selectedAgents.find((agent) => agent.active)
+      : agentCount > 0 && shownAgents > inactiveShownAgents;
   const agents = selectionMode === 'manual' ? selectedAgents : selectionQuery;
 
   const [tagsPopoverButton, setTagsPopoverButton] = useState<HTMLElement>();

x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/search_and_filter_bar.tsx

@@ -59,6 +59,7 @@ export interface SearchAndFilterBarProps {
   inactiveShownAgents: number;
   totalInactiveAgents: number;
   totalManagedAgentIds: string[];
+  inactiveManagedAgentIds: string[];
   selectionMode: SelectionMode;
   currentQuery: string;
   selectedAgents: Agent[];
@@ -88,6 +89,7 @@ export const SearchAndFilterBar: React.FunctionComponent<SearchAndFilterBarProps
   inactiveShownAgents,
   totalInactiveAgents,
   totalManagedAgentIds,
+  inactiveManagedAgentIds,
   selectionMode,
   currentQuery,
   selectedAgents,
@@ -340,6 +342,7 @@ export const SearchAndFilterBar: React.FunctionComponent<SearchAndFilterBarProps
                   shownAgents={shownAgents}
                   inactiveShownAgents={inactiveShownAgents}
                   totalManagedAgentIds={totalManagedAgentIds}
+                  inactiveManagedAgentIds={inactiveManagedAgentIds}
                   selectionMode={selectionMode}
                   currentQuery={currentQuery}
                   selectedAgents={selectedAgents}

x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/index.tsx

@@ -188,6 +188,7 @@ export const AgentListPage: React.FunctionComponent<{}> = () => {
   const [inactiveShownAgents, setInactiveShownAgents] = useState(0);
   const [totalInactiveAgents, setTotalInactiveAgents] = useState(0);
   const [totalManagedAgentIds, setTotalManagedAgentIds] = useState<string[]>([]);
+  const [inactiveManagedAgentIds, setInactiveManagedAgentIds] = useState<string[]>([]);
   const [managedAgentsOnCurrentPage, setManagedAgentsOnCurrentPage] = useState(0);
   const [showAgentActivityTour, setShowAgentActivityTour] = useState({ isOpen: false });
   const getSortFieldForAPI = (field: keyof Agent): string => {
@@ -335,7 +336,11 @@ export const AgentListPage: React.FunctionComponent<{}> = () => {
             }
             const allManagedAgents = response.data?.items ?? [];
             const allManagedAgentIds = allManagedAgents?.map((agent) => agent.id);
+            const inactiveManagedIds = allManagedAgents
+              ?.filter((agent) => agent.status === 'inactive')
+              .map((agent) => agent.id);
             setTotalManagedAgentIds(allManagedAgentIds);
+            setInactiveManagedAgentIds(inactiveManagedIds);
 
             setManagedAgentsOnCurrentPage(
               agentsResponse.data.items
@@ -606,6 +611,7 @@ export const AgentListPage: React.FunctionComponent<{}> = () => {
         inactiveShownAgents={inactiveShownAgents}
         totalInactiveAgents={totalInactiveAgents}
         totalManagedAgentIds={totalManagedAgentIds}
+        inactiveManagedAgentIds={inactiveManagedAgentIds}
         selectionMode={selectionMode}
         currentQuery={kuery}
         selectedAgents={selectedAgents}