-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alert details page][Custom threshold] Add group by and tags fields to the alert details page summary #174254
[Alert details page][Custom threshold] Add group by and tags fields to the alert details page summary #174254
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/ci |
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I can also hide tags if we don't have any. @maciejforcone What do you think? Is it better to hide tags or just show a |
I also think that we can just hide tags header in this case. |
@benakansara I checked the code, and I saw I was checking if tags exist, but in our case, tags are an empty array, and because of that, the code didn't work correctly. I fixed it in this commit: 87bab8e |
@maryam-saeidi @maciejforcone Should we adjust spacing around tags when there are less number of tags (first screenshot below)? We can show all alert summary fields (source, tags, any other) equally spaced, wdyt? |
If you mean to spread the content to fill the whole row, personally, I like the current structure better. CurrentWith
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
…o the alert details page summary (elastic#174254) Closes elastic#155698 Closes elastic#174236 ## Summary This PR adds group and tag information to the alert details page summary fields for the custom threshold rule: ![image](https://github.com/elastic/kibana/assets/12370520/d93e32bd-99ae-414f-87ed-5ca5884acfa6) ## 🧪 How to test - Enable alert details page config ``` xpack.observability.unsafe.alertDetails.observability.enabled: true ``` - Create a custom threshold rule with a group by and add more than 3 rule tags - After the alert is fired, go to the alert details page (from alert flyout or menu action in the alert table); you should see the group by and tags information there.
Closes #155698
Closes #174236
Summary
This PR adds group and tag information to the alert details page summary fields for the custom threshold rule:
🧪 How to test