[Security Solution][API testing] Move and restructures Lists APIS

.buildkite/ftr_configs.yml

@@ -333,7 +333,6 @@ enabled:
   - x-pack/test/kubernetes_security/basic/config.ts
   - x-pack/test/licensing_plugin/config.public.ts
   - x-pack/test/licensing_plugin/config.ts
-  - x-pack/test/lists_api_integration/security_and_spaces/config.ts
   - x-pack/test/monitoring_api_integration/config.ts
   - x-pack/test/observability_api_integration/basic/config.ts
   - x-pack/test/observability_api_integration/trial/config.ts
@@ -492,4 +491,9 @@ enabled:
   - x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/telemetry/configs/ess.config.ts
   - x-pack/test/security_solution_api_integration/test_suites/detections_response/basic_essentials_license/detection_engine/configs/serverless.config.ts
   - x-pack/test/security_solution_api_integration/test_suites/detections_response/basic_essentials_license/detection_engine/configs/ess.config.ts
+  - x-pack/test/security_solution_api_integration/test_suites/lists_and_exception_lists/default_license/exception_lists_items/configs/serverless.config.ts
+  - x-pack/test/security_solution_api_integration/test_suites/lists_and_exception_lists/default_license/exception_lists_items/configs/ess.config.ts
+  - x-pack/test/security_solution_api_integration/test_suites/lists_and_exception_lists/default_license/lists_items/configs/serverless.config.ts
+  - x-pack/test/security_solution_api_integration/test_suites/lists_and_exception_lists/default_license/lists_items/configs/ess.config.ts
+
 

.github/CODEOWNERS

@@ -1223,7 +1223,6 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib
 /x-pack/test/functional/es_archives/endpoint/ @elastic/security-solution
 /x-pack/test/plugin_functional/test_suites/resolver/ @elastic/security-solution
 /x-pack/test/detection_engine_api_integration @elastic/security-solution
-/x-pack/test/lists_api_integration @elastic/security-solution
 /x-pack/test/api_integration/apis/security_solution @elastic/security-solution
 #CC# /x-pack/plugins/security_solution/ @elastic/security-solution
 
@@ -1394,13 +1393,14 @@ x-pack/test/security_solution_cypress/cypress/tasks/expandable_flyout  @elastic/
 /x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics @elastic/security-detection-engine
 /x-pack/test/security_solution_cypress/cypress/e2e/exceptions @elastic/security-detection-engine
 /x-pack/test/security_solution_cypress/cypress/e2e/overview @elastic/security-detection-engine
-x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions  @elastic/security-detection-engine
-x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/rule_creation @elastic/security-detection-engine
-x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/actions @elastic/security-detection-engine
-x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/alerts @elastic/security-detection-engine
-x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/user_roles  @elastic/security-detection-engine
-x-pack/test/security_solution_api_integration/test_suites/detections_response/basic_essentials_license/detection_engine @elastic/security-detection-engine
+/x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions  @elastic/security-detection-engine
+/x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/rule_creation @elastic/security-detection-engine
+/x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/actions @elastic/security-detection-engine
+/x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/alerts @elastic/security-detection-engine
+/x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/user_roles  @elastic/security-detection-engine
+/x-pack/test/security_solution_api_integration/test_suites/detections_response/basic_essentials_license/detection_engine @elastic/security-detection-engine
 /x-pack/plugins/security_solution/server/lib/detection_engine/scripts/roles_users @elastic/security-detection-engine
+/x-pack/test/security_solution_api_integration/test_suites/lists_and_exception_lists @elastic/security-detection-engine
 
 ## Security Threat Intelligence - Under Security Platform
 /x-pack/plugins/security_solution/public/common/components/threat_match @elastic/security-detection-engine

x-pack/plugins/lists/common/schemas/response/exception_list_item_schema.mock.ts

@@ -53,18 +53,19 @@ export const getExceptionListItemSchemaMock = (
  * This is useful for end to end tests where we remove the auto generated parts for comparisons
  * such as created_at, updated_at, and id.
  */
-export const getExceptionListItemResponseMockWithoutAutoGeneratedValues =
-  (): Partial<ExceptionListItemSchema> => ({
-    comments: [],
-    created_by: ELASTIC_USER,
-    description: DESCRIPTION,
-    entries: ENTRIES,
-    item_id: ITEM_ID,
-    list_id: LIST_ID,
-    name: NAME,
-    namespace_type: 'single',
-    os_types: OS_TYPES,
-    tags: [],
-    type: ITEM_TYPE,
-    updated_by: ELASTIC_USER,
-  });
+export const getExceptionListItemResponseMockWithoutAutoGeneratedValues = (
+  elasticUser: string = ELASTIC_USER
+): Partial<ExceptionListItemSchema> => ({
+  comments: [],
+  created_by: elasticUser,
+  description: DESCRIPTION,
+  entries: ENTRIES,
+  item_id: ITEM_ID,
+  list_id: LIST_ID,
+  name: NAME,
+  namespace_type: 'single',
+  os_types: OS_TYPES,
+  tags: [],
+  type: ITEM_TYPE,
+  updated_by: elasticUser,
+});

x-pack/plugins/lists/common/schemas/response/exception_list_schema.mock.ts

@@ -82,17 +82,18 @@ export const getTrustedAppsListSchemaMock = (): ExceptionListSchema => {
  * This is useful for end to end tests where we remove the auto generated parts for comparisons
  * such as created_at, updated_at, and id.
  */
-export const getExceptionResponseMockWithoutAutoGeneratedValues =
-  (): Partial<ExceptionListSchema> => ({
-    created_by: ELASTIC_USER,
-    description: DESCRIPTION,
-    immutable: IMMUTABLE,
-    list_id: LIST_ID,
-    name: NAME,
-    namespace_type: 'single',
-    os_types: [],
-    tags: [],
-    type: ENDPOINT_TYPE,
-    updated_by: ELASTIC_USER,
-    version: VERSION,
-  });
+export const getExceptionResponseMockWithoutAutoGeneratedValues = (
+  elasticUser: string = ELASTIC_USER
+): Partial<ExceptionListSchema> => ({
+  created_by: elasticUser,
+  description: DESCRIPTION,
+  immutable: IMMUTABLE,
+  list_id: LIST_ID,
+  name: NAME,
+  namespace_type: 'single',
+  os_types: [],
+  tags: [],
+  type: ENDPOINT_TYPE,
+  updated_by: elasticUser,
+  version: VERSION,
+});

x-pack/plugins/lists/common/schemas/response/list_item_schema.mock.ts

@@ -40,10 +40,12 @@ export const getListItemResponseMock = (): ListItemSchema => ({
  * This is useful for end to end tests where we remove the auto generated parts for comparisons
  * such as created_at, updated_at, and id.
  */
-export const getListItemResponseMockWithoutAutoGeneratedValues = (): Partial<ListItemSchema> => ({
-  created_by: ELASTIC_USER,
+export const getListItemResponseMockWithoutAutoGeneratedValues = (
+  elasticUser: string = ELASTIC_USER
+): Partial<ListItemSchema> => ({
+  created_by: elasticUser,
   list_id: LIST_ID,
   type: TYPE,
-  updated_by: ELASTIC_USER,
+  updated_by: elasticUser,
   value: VALUE,
 });

x-pack/plugins/lists/common/schemas/response/list_schema.mock.ts

@@ -44,12 +44,14 @@ export const getListResponseMock = (): ListSchema => ({
  * This is useful for end to end tests where we remove the auto generated parts for comparisons
  * such as created_at, updated_at, and id.
  */
-export const getListResponseMockWithoutAutoGeneratedValues = (): Partial<ListSchema> => ({
-  created_by: ELASTIC_USER,
+export const getListResponseMockWithoutAutoGeneratedValues = (
+  elasticUser: string = ELASTIC_USER
+): Partial<ListSchema> => ({
+  created_by: elasticUser,
   description: DESCRIPTION,
   immutable: IMMUTABLE,
   name: NAME,
   type: TYPE,
-  updated_by: ELASTIC_USER,
+  updated_by: elasticUser,
   version: VERSION,
 });

x-pack/test/detection_engine_api_integration/security_and_spaces/group10/import_export_rules.ts

@@ -26,8 +26,8 @@ import {
   deleteAllRules,
   deleteAllAlerts,
   getSimpleRule,
+  deleteAllExceptions,
 } from '../../utils';
-import { deleteAllExceptions } from '../../../lists_api_integration/utils';
 import { createUserAndRole, deleteUserAndRole } from '../../../common/services/security_solution';
 
 // This test was meant to be more full flow, ensuring that

x-pack/test/detection_engine_api_integration/security_and_spaces/group10/import_rules.ts

@@ -38,8 +38,8 @@ import {
   createRule,
   getRule,
   getRuleSOById,
+  deleteAllExceptions,
 } from '../../utils';
-import { deleteAllExceptions } from '../../../lists_api_integration/utils';
 import { createUserAndRole, deleteUserAndRole } from '../../../common/services/security_solution';
 
 const getImportRuleBuffer = (connectorId: string) => {

x-pack/test/detection_engine_api_integration/security_and_spaces/group10/perform_bulk_action.ts

@@ -23,7 +23,6 @@ import { getCreateExceptionListDetectionSchemaMock } from '@kbn/lists-plugin/com
 import { EXCEPTION_LIST_ITEM_URL, EXCEPTION_LIST_URL } from '@kbn/securitysolution-list-constants';
 import { getCreateExceptionListItemMinimalSchemaMock } from '@kbn/lists-plugin/common/schemas/request/create_exception_list_item_schema.mock';
 import { WebhookAuthType } from '@kbn/stack-connectors-plugin/common/webhook/constants';
-import { deleteAllExceptions } from '../../../lists_api_integration/utils';
 import {
   binaryToString,
   createLegacyRuleAction,
@@ -44,6 +43,7 @@ import {
   createRuleThroughAlertingEndpoint,
   getRuleSavedObjectWithLegacyInvestigationFields,
   getRuleSavedObjectWithLegacyInvestigationFieldsEmptyArray,
+  deleteAllExceptions,
 } from '../../utils';
 import { FtrProviderContext } from '../../common/ftr_provider_context';
 

x-pack/test/detection_engine_api_integration/security_and_spaces/tests/import_rules.ts

@@ -27,8 +27,8 @@ import {
   getWebHookAction,
   removeServerGeneratedProperties,
   ruleToNdjson,
+  deleteAllExceptions,
 } from '../../utils';
-import { deleteAllExceptions } from '../../../lists_api_integration/utils';
 import { createUserAndRole, deleteUserAndRole } from '../../../common/services/security_solution';
 
 const getImportRuleBuffer = (connectorId: string) => {

x-pack/test/detection_engine_api_integration/utils/delete_all_exceptions.ts

@@ -0,0 +1,67 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+// Should be deleted once all all the remaining tests in this folder get moved to the new /security_solution_api_integration folder
+
+import type SuperTest from 'supertest';
+
+import type { ExceptionList, NamespaceType } from '@kbn/securitysolution-io-ts-list-types';
+import { EXCEPTION_LIST_URL } from '@kbn/securitysolution-list-constants';
+
+import { ToolingLog } from '@kbn/tooling-log';
+import { countDownTest } from './count_down_test';
+
+/**
+ * Remove all exceptions from both the "single" and "agnostic" spaces.
+ * This will retry 50 times before giving up and hopefully still not interfere with other tests
+ * @param supertest The supertest handle
+ */
+export const deleteAllExceptions = async (
+  supertest: SuperTest.SuperTest<SuperTest.Test>,
+  log: ToolingLog
+): Promise<void> => {
+  await deleteAllExceptionsByType(supertest, log, 'single');
+  await deleteAllExceptionsByType(supertest, log, 'agnostic');
+};
+
+/**
+ * Remove all exceptions by a given type such as "agnostic" or "single".
+ * This will retry 50 times before giving up and hopefully still not interfere with other tests
+ * @param supertest The supertest handle
+ */
+export const deleteAllExceptionsByType = async (
+  supertest: SuperTest.SuperTest<SuperTest.Test>,
+  log: ToolingLog,
+  type: NamespaceType
+): Promise<void> => {
+  await countDownTest(
+    async () => {
+      const { body } = await supertest
+        .get(`${EXCEPTION_LIST_URL}/_find?per_page=9999&namespace_type=${type}`)
+        .set('kbn-xsrf', 'true')
+        .send();
+      const ids: string[] = body.data.map((exception: ExceptionList) => exception.id);
+      for await (const id of ids) {
+        await supertest
+          .delete(`${EXCEPTION_LIST_URL}?id=${id}&namespace_type=${type}`)
+          .set('kbn-xsrf', 'true')
+          .send();
+      }
+      const { body: finalCheck } = await supertest
+        .get(`${EXCEPTION_LIST_URL}/_find?namespace_type=${type}`)
+        .set('kbn-xsrf', 'true')
+        .send();
+      return {
+        passed: finalCheck.data.length === 0,
+      };
+    },
+    `deleteAllExceptions by type: "${type}"`,
+    log,
+    50,
+    1000
+  );
+};

x-pack/test/detection_engine_api_integration/utils/index.ts

@@ -86,3 +86,4 @@ export * from './prebuilt_rules/delete_all_prebuilt_rule_assets';
 export * from './prebuilt_rules/install_mock_prebuilt_rules';
 export * from './prebuilt_rules/install_prebuilt_rules_and_timelines';
 export * from './get_legacy_action_so';
+export * from './delete_all_exceptions';