-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][API testing] Move and restructures Lists APIS #171992
Conversation
…ructure-list-apis
…sr/kibana into move-structure-list-apis
…sr/kibana into move-structure-list-apis
…ructure-list-apis
…ructure-list-apis
…l we move the rule managment files to the new folder
…ructure-list-apis
…sr/kibana into move-structure-list-apis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from SDA perspective ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review all code-owners file, I assume for EA and DE.
LGTM, thank you very much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm on the ops side
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @WafaaNasr |
Summary
Following the initial work in this #166755
Addresses part of [Security Solution] Restructure API integration tests into meaningful groups that run in parallel on CI #151902 for List APIs tests
Added a new folder under the
security_solution_api_integration
calledlists_and_exception_lists
to hold the lists and exception lists tests, and split theList
APIs into two groups since the execution time in Serverless was close to 30 minsModified the x-pack/plugins/lists/common/schemas/response/exception_list_item_schema.mock.ts, x-pack/plugins/lists/common/schemas/response/exception_list_schema.mock.ts , x-pack/plugins/lists/common/schemas/response/list_item_schema.mock.ts, x-pack/plugins/lists/common/schemas/response/list_schema.mock.ts to accept
elastic user
input because it changes in ESS and ServerlessDeleted the
x-pack/test/lists_api_integration
folderMoved the utility files associated with Basic tests to the new directory
security_solution_api_integration
. Files not actively used in the previous folder were moved, while duplicate files remained in their original positions.Updated the below files imports from the old
lists_api_integration
folder to the newlists_and_exception_lists
Updated the below files imports to the
ftr_provider_context_with_spaces.d.ts
- risk_engine/risk_scoring_task/task_execution_nondefault_spaces.ts
The QA phase concluded with all tests passing successfully. 🟢
Updated the CodeOwner file for the newly moved tests
Add a new util file to
deleteAllExceptions
under the olddetection_engine_api
folder since the Rule management related-tests are still need to be moved over to the new folderOld/new group details, decisions, and execution time are mentioned in this document